2010-11-09 04:24:07

by Ralf Baechle

Subject: Re: [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment

On Tue, Oct 26, 2010 at 12:25:35PM +0200, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> Delete successive assignments to the same location.

[...]

> This change also makes the variable cpu_clock_freq be not used in the
> current file. If this is the correct change to plat_time_init, then
> perhaps the declaration of that variable should be moved elsewhere, or the
> variable should be deleted completely.

The 2nd assignment is a temporary override for debugging purpose that is
it's there intionsionally.

Thanks!

Ralf

2010-11-09 07:10:33

by Julia Lawall

Subject: Re: [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: delete double assignment

On Tue, 9 Nov 2010, Ralf Baechle wrote:

> On Tue, Oct 26, 2010 at 12:25:35PM +0200, Julia Lawall wrote:
> > From: Julia Lawall <[email protected]>
> >
> > Delete successive assignments to the same location.
>
> [...]
>
> > This change also makes the variable cpu_clock_freq be not used in the
> > current file. If this is the correct change to plat_time_init, then
> > perhaps the declaration of that variable should be moved elsewhere, or the
> > variable should be deleted completely.
>
> The 2nd assignment is a temporary override for debugging purpose that is
> it's there intionsionally.

OK, thanks. I indeed suspected that, but I thought it might be worthwhile
to mention it, in case it had outlived its usefulness.

julia