2013-10-13 06:01:54

by Michael Opdenacker

Subject: [PATCH] [media] sh_mobile_ceu_camera: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <[email protected]>
---
drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
index 8df22f7..150bd4d 100644
--- a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
+++ b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
@@ -1800,7 +1800,7 @@ static int sh_mobile_ceu_probe(struct platform_device *pdev)

/* request irq */
err = devm_request_irq(&pdev->dev, pcdev->irq, sh_mobile_ceu_irq,
- IRQF_DISABLED, dev_name(&pdev->dev), pcdev);
+ 0, dev_name(&pdev->dev), pcdev);
if (err) {
dev_err(&pdev->dev, "Unable to register CEU interrupt.\n");
goto exit_release_mem;
--
1.8.1.2

2013-10-14 10:03:20

by Guennadi Liakhovetski

Subject: Re: [PATCH] [media] sh_mobile_ceu_camera: remove deprecated IRQF_DISABLED

Hi Michael,

Thanks for the patch. Since patches in the series are independent from
each other, I can take this one via my tree, which would be preferred.
Otherwise I can ack it and we can push it via another tree.

Thanks
Guennadi

On Sun, 13 Oct 2013, Michael Opdenacker wrote:

> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
> drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
> index 8df22f7..150bd4d 100644
> --- a/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
> +++ b/drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c
> @@ -1800,7 +1800,7 @@ static int sh_mobile_ceu_probe(struct platform_device *pdev)
>
> /* request irq */
> err = devm_request_irq(&pdev->dev, pcdev->irq, sh_mobile_ceu_irq,
> - IRQF_DISABLED, dev_name(&pdev->dev), pcdev);
> + 0, dev_name(&pdev->dev), pcdev);
> if (err) {
> dev_err(&pdev->dev, "Unable to register CEU interrupt.\n");
> goto exit_release_mem;
> --
> 1.8.1.2
>

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

2013-10-14 11:16:03

by Michael Opdenacker

Subject: Re: [PATCH] [media] sh_mobile_ceu_camera: remove deprecated IRQF_DISABLED

Hi Guennadi,

On 10/14/2013 12:03 PM, Guennadi Liakhovetski wrote:
> Hi Michael,
>
> Thanks for the patch. Since patches in the series are independent from
> each other, I can take this one via my tree, which would be preferred.
> Otherwise I can ack it and we can push it via another tree.
It's fine for me if you can push it through your tree!

Many thanks!

Cheers,

Michael.

--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098