2006-11-19 19:24:19

by David Rientjes

Subject: [PATCH] i386 cpufreq: cs5530A allows active idle

The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
revision should be accurately stored.

Cc: Hiroshi Miura <[email protected]>
Cc: Dave Jones <[email protected]>
Cc: Zwane Mwaikambo <[email protected]>
Signed-off-by: David Rientjes <[email protected]>
---
arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
index 92afa3b..0b9cc8a 100644
--- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
+++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
@@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
- params->pci_rev = class_rev && 0xff;
+ params->pci_rev = class_rev & 0xff;

if ((ret = cpufreq_register_driver(&gx_suspmod_driver))) {
kfree(params);

2006-11-19 20:55:18

by Dave Jones

Subject: Re: [PATCH] i386 cpufreq: cs5530A allows active idle

On Sun, Nov 19, 2006 at 11:24:08AM -0800, David Rientjes wrote:
> The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
> revision should be accurately stored.

Already queued in cpufreq.git for .20

Dave

--
http://www.codemonkey.org.uk

2006-11-20 00:48:38

by Alan

Subject: Re: [PATCH] i386 cpufreq: cs5530A allows active idle

On Sun, 19 Nov 2006 15:55:03 -0500
Dave Jones <[email protected]> wrote:

> On Sun, Nov 19, 2006 at 11:24:08AM -0800, David Rientjes wrote:
> > The cs5530A will be able to go into active idle (PWRSVE) so its PCI class
> > revision should be accurately stored.
>
> Already queued in cpufreq.git for .20

CS5530 doesn't currently work correctly with suspend/resume anyway - you
need to restore the various SMM setups that are lost such as the VGA SMM
trap bit.

Alan