2000-12-28 22:12:36

by Rik van Riel

[permalink] [raw]
Subject: [PATCH] 8139too fix

Hi,

with the fix below, newer versions of modutils won't
complain about the (missing) symbol debug...

Could you please apply this for the next pre-patch?

thanks,

Rik
--
Hollywood goes for world dumbination,
Trailer at 11.

http://www.surriel.com/
http://www.conectiva.com/ http://distro.conectiva.com.br/



--- ./drivers/net/8139too.c.wrong Thu Dec 28 19:39:18 2000
+++ ./drivers/net/8139too.c Thu Dec 28 19:39:26 2000
@@ -536,7 +536,6 @@
MODULE_DESCRIPTION ("RealTek RTL-8139 Fast Ethernet driver");
MODULE_PARM (multicast_filter_limit, "i");
MODULE_PARM (max_interrupt_work, "i");
-MODULE_PARM (debug, "i");
MODULE_PARM (media, "1-" __MODULE_STRING(8) "i");

static int read_eeprom (void *ioaddr, int location, int addr_len);


2000-12-28 22:24:06

by Andre Hedrick

[permalink] [raw]
Subject: Re: [PATCH] 8139too fix


Jeff Garzik, is offline for the next three weeks......

He claims that his wrists hurt from the keyboard ;-)...

Cheers,

Andre Hedrick
CTO Timpanogas Research Group
EVP Linux Development, TRG
Linux ATA Development

2000-12-29 20:14:20

by Mike Galbraith

[permalink] [raw]
Subject: Re: [PATCH] 8139too fix

On Thu, 28 Dec 2000, Andre Hedrick wrote:

[I was going to send brief comment offline, but maybe this
will give someone pause for thought...]

> Jeff Garzik, is offline for the next three weeks......
>
> He claims that his wrists hurt from the keyboard ;-)...

And if his wrists hurt, he's definitely doing the right
thing by laying off.

<soapbox>
I _know_:
8 months in a neck brace due to cervical spine damage
(don't hunch forward while reading cool/clever code).
1.5 years physical therapy for that damage (permanent,
_do not_ hunch forward while reading cool/clever code).
7 months paralysis of left arm (don't put weight on your
elbow on hard surface while reading cool/clever code)
5 months paralysis of lower left leg (don't cross your
legs while leaning on left elbow while...).

The nerve damage can be helped a bit with massive doses of
vitamine B if you're lucky, but they don't fully recover in
my experience. Bones don't recover at all.. ever.

Remember the thousand times your mom said sit up straight?..
I sure do ;-)
</soapbox>

-Mike