2002-08-13 04:09:03

by John Kim

[permalink] [raw]
Subject: devfs compile breaks on 2.4.20-pre2


devfs is seems to be broken for 2.4.20-pre2 because include/linux/genhd.h
has been modified from 2.4.20-pre1. I see that 'number' member has been
removed from hd_struct in include/linux/genhd.h.

Functions devfs_register_disc and devfs_register_partitions in
fs/partitions/check.c is still expecting "number" it to be there.

Unfortunately I don't know enough about devfs (or kernel in general) to
fix this. My apologies if this mailing list wrong place to report
problems like this.


John Kim


2002-08-13 08:38:28

by Adrian Bunk

[permalink] [raw]
Subject: Re: devfs compile breaks on 2.4.20-pre2

On Tue, 13 Aug 2002, John Kim wrote:

> has been modified from 2.4.20-pre1. I see that 'number' member has been
> removed from hd_struct in include/linux/genhd.h.
>
> Functions devfs_register_disc and devfs_register_partitions in
> fs/partitions/check.c is still expecting "number" it to be there.
>...


The following patch made by Christoph Hellwig fixes it:


--- linux-2.4.20-bk-20020810/include/linux/genhd.h Sat Aug 10 14:37:16 2002
+++ linux/include/linux/genhd.h Mon Aug 12 23:40:37 2002
@@ -62,7 +62,9 @@ struct hd_struct {
unsigned long start_sect;
unsigned long nr_sects;
devfs_handle_t de; /* primary (master) devfs entry */
-
+#ifdef CONFIG_DEVFS_FS
+ int number;
+#endif /* CONFIG_DEVFS_FS */
#ifdef CONFIG_BLK_STATS
/* Performance stats: */
unsigned int ios_in_flight;

> John Kim

cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox