Hallo lkml,
I'm sending 2 patches to fix compilation errors in the AFS fs.
The first of them fixed union afs_dirent_t and using this union in the
fs/afs/dir.c.
The second of them fix number of parameters of calling function kleave()
in the net/rxpc/main.c.
Sincerely
Jan Marek
--
Ing. Jan Marek
University of South Bohemia
Academic Computer Centre
Phone: +420-38-7772080
On Wed, 2002-10-23 at 10:56, Jan Marek wrote:
> Hallo lkml,
>
> I'm sending 2 patches to fix compilation errors in the AFS fs.
>
> The first of them fixed union afs_dirent_t and using this union in the
> fs/afs/dir.c.
>
What compiler are you using, this is building fine with the gcc's I
have. Is it 2.95 ?
On 23 Oct 2002, Alan Cox wrote:
> On Wed, 2002-10-23 at 10:56, Jan Marek wrote:
> > Hallo lkml,
> >
> > I'm sending 2 patches to fix compilation errors in the AFS fs.
> >
> > The first of them fixed union afs_dirent_t and using this union in the
> > fs/afs/dir.c.
> >
>
> What compiler are you using, this is building fine with the gcc's I
> have. Is it 2.95 ?
Most likely. Below is the error I see when trying to compile this file
with 2.95:
<-- snip -->
...
gcc -Wp,-MD,fs/afs/.dir.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=k6 -Iarch/i386/mach-generic -nostdinc
-iwithprefix include -DKBUILD_BASENAME=dir -c -o fs/afs/dir.o fs/afs/dir.c
fs/afs/dir.c:75: warning: unnamed struct/union that defines no instances
fs/afs/dir.c: In function `afs_dir_iterate_block':
fs/afs/dir.c:261: union has no member named `name'
fs/afs/dir.c:293: union has no member named `name'
fs/afs/dir.c:296: union has no member named `vnode'
fs/afs/dir.c:296: union has no member named `vnode'
fs/afs/dir.c:296: union has no member named `vnode'
fs/afs/dir.c:297: union has no member named `unique'
make[2]: *** [fs/afs/dir.o] Error 1
<-- snip -->
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
On Wed, Oct 23, 2002 at 11:28:16AM +0100, Alan Cox wrote:
> On Wed, 2002-10-23 at 10:56, Jan Marek wrote:
> > The first of them fixed union afs_dirent_t and using this union in the
> > fs/afs/dir.c.
>
> What compiler are you using, this is building fine with the gcc's I
> have. Is it 2.95 ?
It doesn't compile with 2.95.4 from debian's 2.95.4-12. It does compile
with gcc-3.x, where unnamed struct/union members seem to be introduced.
-alex
On Wed, 2002-10-23 at 11:42, Alex Riesen wrote:
> On Wed, Oct 23, 2002 at 11:28:16AM +0100, Alan Cox wrote:
> > On Wed, 2002-10-23 at 10:56, Jan Marek wrote:
> > > The first of them fixed union afs_dirent_t and using this union in the
> > > fs/afs/dir.c.
> >
> > What compiler are you using, this is building fine with the gcc's I
> > have. Is it 2.95 ?
>
> It doesn't compile with 2.95.4 from debian's 2.95.4-12. It does compile
> with gcc-3.x, where unnamed struct/union members seem to be introduced.
Makes sense then. Applied
On Wed, 2002-10-23 at 03:28, Alan Cox wrote:
> On Wed, 2002-10-23 at 10:56, Jan Marek wrote:
> > The first of them fixed union afs_dirent_t and using this union in the
> > fs/afs/dir.c.
> >
>
> What compiler are you using, this is building fine with the gcc's I
> have. Is it 2.95 ?
David Howells has a full set of patches to clean up the
2.95 issues in AFS, they just didn't get integrated before
Linus took off.