On 23/03/2022 16:14, Krzysztof Kozlowski wrote:
> On 23/03/2022 16:03, Jonathan Bakker wrote:
>> Based on the device tree spec, clocks should be ordered tx/rx.
>> Re-order from rx/tx to avoid warnings when running make dtbs_check
>>
>> Additionally, the number of #sound-dai-cells should be 1, not 0
>>
>> Signed-off-by: Jonathan Bakker <[email protected]>
>> ---
>> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
>> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>> index 70ff56daf4cb..503b5a50ef1a 100644
>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>> @@ -644,7 +644,7 @@
>> };
>>
>> &i2s0 {
>> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
>> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>> status = "okay";
>
> Except that fix that's the same commit as here:
> https://lore.kernel.org/all/[email protected]/
> so just extend it.
>
> sound-dai-cells should go to a separate commit. But are you sure they
> are correct? The Fascinate 4G seems to be using them as cells=0.
See my previous patch and discussion:
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
Hi Krzysztof,
On 2022-03-23 8:15 a.m., Krzysztof Kozlowski wrote:
> On 23/03/2022 16:14, Krzysztof Kozlowski wrote:
>> On 23/03/2022 16:03, Jonathan Bakker wrote:
>>> Based on the device tree spec, clocks should be ordered tx/rx.
>>> Re-order from rx/tx to avoid warnings when running make dtbs_check
>>>
>>> Additionally, the number of #sound-dai-cells should be 1, not 0
>>>
>>> Signed-off-by: Jonathan Bakker <[email protected]>
>>> ---
>>> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
>>> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
>>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>> index 70ff56daf4cb..503b5a50ef1a 100644
>>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>> @@ -644,7 +644,7 @@
>>> };
>>>
>>> &i2s0 {
>>> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
>>> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>>> status = "okay";
>>
>> Except that fix that's the same commit as here:
>> https://lore.kernel.org/all/[email protected]/
>> so just extend it.
>>
>> sound-dai-cells should go to a separate commit. But are you sure they
>> are correct? The Fascinate 4G seems to be using them as cells=0.
>
> See my previous patch and discussion:
> https://lore.kernel.org/all/[email protected]/
>
Thanks, I'd totally forgotten about this series from the past. I'll re-test
those commits and submit your copies of them in v2 if that's OK with you and
that they're confirmed functional?
Jonathan
>
> Best regards,
> Krzysztof
>
On 23/03/2022 18:24, Jonathan Bakker wrote:
> Hi Krzysztof,
>
> On 2022-03-23 8:15 a.m., Krzysztof Kozlowski wrote:
>> On 23/03/2022 16:14, Krzysztof Kozlowski wrote:
>>> On 23/03/2022 16:03, Jonathan Bakker wrote:
>>>> Based on the device tree spec, clocks should be ordered tx/rx.
>>>> Re-order from rx/tx to avoid warnings when running make dtbs_check
>>>>
>>>> Additionally, the number of #sound-dai-cells should be 1, not 0
>>>>
>>>> Signed-off-by: Jonathan Bakker <[email protected]>
>>>> ---
>>>> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
>>>> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
>>>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>> index 70ff56daf4cb..503b5a50ef1a 100644
>>>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>> @@ -644,7 +644,7 @@
>>>> };
>>>>
>>>> &i2s0 {
>>>> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
>>>> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>>>> status = "okay";
>>>
>>> Except that fix that's the same commit as here:
>>> https://lore.kernel.org/all/[email protected]/
>>> so just extend it.
>>>
>>> sound-dai-cells should go to a separate commit. But are you sure they
>>> are correct? The Fascinate 4G seems to be using them as cells=0.
>>
>> See my previous patch and discussion:
>> https://lore.kernel.org/all/[email protected]/
>>
>
> Thanks, I'd totally forgotten about this series from the past. I'll re-test
> those commits and submit your copies of them in v2 if that's OK with you and
> that they're confirmed functional?
My dma fixes change lacked this aries fix. The sound-dai-cells needed
more rethinking.
Best regards,
Krzysztof
On 24/03/2022 12:49, Krzysztof Kozlowski wrote:
> On 23/03/2022 18:24, Jonathan Bakker wrote:
>> Hi Krzysztof,
>>
>> On 2022-03-23 8:15 a.m., Krzysztof Kozlowski wrote:
>>> On 23/03/2022 16:14, Krzysztof Kozlowski wrote:
>>>> On 23/03/2022 16:03, Jonathan Bakker wrote:
>>>>> Based on the device tree spec, clocks should be ordered tx/rx.
>>>>> Re-order from rx/tx to avoid warnings when running make dtbs_check
>>>>>
>>>>> Additionally, the number of #sound-dai-cells should be 1, not 0
>>>>>
>>>>> Signed-off-by: Jonathan Bakker <[email protected]>
>>>>> ---
>>>>> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
>>>>> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
>>>>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> index 70ff56daf4cb..503b5a50ef1a 100644
>>>>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> @@ -644,7 +644,7 @@
>>>>> };
>>>>>
>>>>> &i2s0 {
>>>>> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
>>>>> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>>>>> status = "okay";
>>>>
>>>> Except that fix that's the same commit as here:
>>>> https://lore.kernel.org/all/[email protected]/
>>>> so just extend it.
>>>>
>>>> sound-dai-cells should go to a separate commit. But are you sure they
>>>> are correct? The Fascinate 4G seems to be using them as cells=0.
>>>
>>> See my previous patch and discussion:
>>> https://lore.kernel.org/all/[email protected]/
>>>
>>
>> Thanks, I'd totally forgotten about this series from the past. I'll re-test
>> those commits and submit your copies of them in v2 if that's OK with you and
>> that they're confirmed functional?
>
> My dma fixes change lacked this aries fix. The sound-dai-cells needed
> more rethinking.
>
Hi Jonathan,
Any plans for checking/fixing/testing and resending the sound-dai-cells
fixes?
Best regards,
Krzysztof
On 2023-04-21 02:44, Krzysztof Kozlowski wrote:
> On 24/03/2022 12:49, Krzysztof Kozlowski wrote:
>> On 23/03/2022 18:24, Jonathan Bakker wrote:
>>> Hi Krzysztof,
>>>
>>> On 2022-03-23 8:15 a.m., Krzysztof Kozlowski wrote:
>>>> On 23/03/2022 16:14, Krzysztof Kozlowski wrote:
>>>>> On 23/03/2022 16:03, Jonathan Bakker wrote:
>>>>>> Based on the device tree spec, clocks should be ordered tx/rx.
>>>>>> Re-order from rx/tx to avoid warnings when running make dtbs_check
>>>>>>
>>>>>> Additionally, the number of #sound-dai-cells should be 1, not 0
>>>>>>
>>>>>> Signed-off-by: Jonathan Bakker <[email protected]>
>>>>>> ---
>>>>>> arch/arm/boot/dts/s5pv210-aries.dtsi | 2 +-
>>>>>> arch/arm/boot/dts/s5pv210.dtsi | 18 +++++++++---------
>>>>>> 2 files changed, 10 insertions(+), 10 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>>> index 70ff56daf4cb..503b5a50ef1a 100644
>>>>>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>>> @@ -644,7 +644,7 @@
>>>>>> };
>>>>>>
>>>>>> &i2s0 {
>>>>>> - dmas = <&pdma0 9>, <&pdma0 10>, <&pdma0 11>;
>>>>>> + dmas = <&pdma0 10>, <&pdma0 9>, <&pdma0 11>;
>>>>>> status = "okay";
>>>>>
>>>>> Except that fix that's the same commit as here:
>>>>> https://lore.kernel.org/all/[email protected]/
>>>>> so just extend it.
>>>>>
>>>>> sound-dai-cells should go to a separate commit. But are you sure they
>>>>> are correct? The Fascinate 4G seems to be using them as cells=0.
>>>>
>>>> See my previous patch and discussion:
>>>> https://lore.kernel.org/all/[email protected]/
>>>>
>>>
>>> Thanks, I'd totally forgotten about this series from the past. I'll re-test
>>> those commits and submit your copies of them in v2 if that's OK with you and
>>> that they're confirmed functional?
>>
>> My dma fixes change lacked this aries fix. The sound-dai-cells needed
>> more rethinking.
>>
>
> Hi Jonathan,
>
> Any plans for checking/fixing/testing and resending the sound-dai-cells
> fixes?
>
> Best regards,
> Krzysztof
>
Oops, I forgot about this again... Unfortunately, I don't really have the time
right now to do so, and don't know when or if I will.
Thanks,
Jonathan