> From: Nathan Huckleberry <[email protected]>
> Sent: Monday, September 12, 2022 2:44 PM
> ...
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of mana_start_xmit should be changed from int to
> netdev_tx_t.
>
> Reported-by: Dan Carpenter <[email protected]>
> Link: ...
> Cc: [email protected]
> Signed-off-by: Nathan Huckleberry <[email protected]>
Reviewed-by: Dexuan Cui <[email protected]>
Thanks for the fix!