2023-12-17 07:23:19

by Parker, Amy

Subject: [PATCH] slab: fix include indentation

Include directives in slab are indented by tabs, except for
trace/events/kmem.h, which is indented with a single space.
This aligns in some editors depending on tab width setting,
but on others causes the directives to be misaligned.
This patch fixes that alignment.

Signed-off-by: Amy Parker <[email protected]>

---
mm/slab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slab.c b/mm/slab.c
index 9ad3d0f2d1a5..e09c44f5b5ac 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -125,7 +125,7 @@
#include <asm/tlbflush.h>
#include <asm/page.h>

-#include <trace/events/kmem.h>
+#include <trace/events/kmem.h>

#include "internal.h"

--
2.43.0

2023-12-18 01:04:19

by Song, Xiongwei

Subject: RE: [PATCH] slab: fix include indentation

> -----Original Message-----
> From: [email protected] <[email protected]> On Behalf
> Of Parker, Amy
> Sent: Sunday, December 17, 2023 3:23 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH] slab: fix include indentation
>
> Include directives in slab are indented by tabs, except for
> trace/events/kmem.h, which is indented with a single space.
> This aligns in some editors depending on tab width setting,
> but on others causes the directives to be misaligned.
> This patch fixes that alignment.
>
> Signed-off-by: Amy Parker <[email protected]>
>
> ---
> mm/slab.c | 2 +-

The current slab allocator is going to be removed.

https://lore.kernel.org/linux-mm/ZXEx1%[email protected]/T/#m1a5899625baa61ad31a0e99eea6fc02258513ac1

Thanks.

> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 9ad3d0f2d1a5..e09c44f5b5ac 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -125,7 +125,7 @@
> #include <asm/tlbflush.h>
> #include <asm/page.h>
>
> -#include <trace/events/kmem.h>
> +#include <trace/events/kmem.h>
>
> #include "internal.h"
>
> --
> 2.43.0

2023-12-18 01:16:35

by Parker, Amy

Subject: Re: [PATCH] slab: fix include indentation

> -----Original Message-----
> From: [email protected] <[email protected]> On Behalf
> Of Parker, Amy
> Sent: Sunday, December 17, 2023 3:23 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]
> Subject: [PATCH] slab: fix include indentation
>
> Include directives in slab are indented by tabs, except for
> trace/events/kmem.h, which is indented with a single space.
> This aligns in some editors depending on tab width setting,
> but on others causes the directives to be misaligned.
> This patch fixes that alignment.
>
> Signed-off-by: Amy Parker <[email protected]>
>
> ---
>? mm/slab.c | 2 +-

> The current slab allocator? is going to be removed.

Hadn't gotten that news. Thanks for the update.

- amyip