2022-09-08 16:09:23

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RESEND PATCH v9 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x

On 08/09/2022 17:06, Kavyasree Kotagiri wrote:
> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
> functions being configured.
>
> Signed-off-by: Kavyasree Kotagiri <[email protected]>

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Best regards,
Krzysztof


2022-09-09 07:28:16

by Kavyasree Kotagiri

[permalink] [raw]
Subject: RE: [RESEND PATCH v9 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x



>
> On 08/09/2022 17:06, Kavyasree Kotagiri wrote:
> > LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> > in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> > can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage
> depends on
> > functions being configured.
> >
> > Signed-off-by: Kavyasree Kotagiri <[email protected]>
>
> Please add Acked-by/Reviewed-by tags when posting new versions.
> However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/subm
> itting-patches.rst#L540
>
> If a tag was not added on purpose, please state why and what changed.
>
Yes, You are right.
I missed adding reviewed-by tag for 2/3 and 3/3 patches(which doesn't have any issues
while applying on latest version)
I haven't added tag for patch-1/3 as there is small change
(i.e., Changed reference provided for spi bindings to atmel,at91rm9200-spi.yaml)
while applying changes on latest version.
>
> Best regards,
> Krzysztof