2024-05-31 07:27:40

by Noah Wang

Subject: [v3,2/2] dt-bindings: hwmon: Add mps mp2891

Add support for mps mp2891 controller

Signed-off-by: Noah Wang <[email protected]>
---
v2 -> v3:
move mp2891 dt-bindings to trivial devices

v1 -> v2:
add mp2891 dt-bindings

Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 025d50454f88..dabbc4cd089e 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -290,6 +290,8 @@ properties:
- mps,mp2973
# Monolithic Power Systems Inc. multi-phase controller mp2975
- mps,mp2975
+ # Monolithic Power Systems Inc. multi-phase controller mp2891
+ - mps,mp2891
# Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
- mps,mp5990
# Monolithic Power Systems Inc. synchronous step-down converter mpq8785
--
2.25.1

2024-05-31 07:34:30

by Krzysztof Kozlowski

Subject: Re: [v3,2/2] dt-bindings: hwmon: Add mps mp2891

On 31/05/2024 09:26, Noah Wang wrote:
> Add support for mps mp2891 controller
>
> Signed-off-by: Noah Wang <[email protected]>
> ---
> v2 -> v3:
> move mp2891 dt-bindings to trivial devices
>
> v1 -> v2:
> add mp2891 dt-bindings
>
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 025d50454f88..dabbc4cd089e 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -290,6 +290,8 @@ properties:
> - mps,mp2973
> # Monolithic Power Systems Inc. multi-phase controller mp2975
> - mps,mp2975
> + # Monolithic Power Systems Inc. multi-phase controller mp2891
> + - mps,mp2891

Please keep the entries sorted.

Best regards,
Krzysztof

2024-05-31 20:45:38

by Bjorn Helgaas

Subject: Re: [v3,2/2] dt-bindings: hwmon: Add mps mp2891

On Fri, May 31, 2024 at 03:26:02PM +0800, Noah Wang wrote:
> Add support for mps mp2891 controller

s/mps/MPS/ in subject and commit log.

When you have more than one patch, it's nice if you can include a
cover letter and send the patches as responses to it. That helps
tools like b4 connect them all together:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst?id=v6.9#n349