2024-03-05 02:20:23

by Yang Xiwen via B4 Relay

Subject: [PATCH v4 4/5] dt-bindings: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy

From: Yang Xiwen <[email protected]>

Hi3798MV200 INNO USB2 PHY is attached directly to system bus. Add
compatible "hisilicon,hi3798mv200-usb2-phy" for it. The ports of
Hi3798MV200 INNO PHY has its own address space, so

Signed-off-by: Yang Xiwen <[email protected]>
---
.../bindings/phy/hisilicon,inno-usb2-phy.yaml | 31 ++++++++++++++++++++--
1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml
index 7f0811a2dc2b..92559bdc4fef 100644
--- a/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/hisilicon,inno-usb2-phy.yaml
@@ -15,6 +15,7 @@ properties:
- enum:
- hisilicon,hi3798cv200-usb2-phy
- hisilicon,hi3798mv100-usb2-phy
+ - hisilicon,hi3798mv200-usb2-phy

reg:
maxItems: 1
@@ -22,18 +23,29 @@ properties:
peripheral controller, e.g. PERI_USB0 for USB 2.0 PHY01 on Hi3798CV200 SoC,
or direct MMIO address space.

+ ranges:
+ maxItems: 1
+
'#address-cells':
const: 1

'#size-cells':
- const: 0
+ enum: [0, 1]

clocks:
maxItems: 1
description: reference clock

resets:
- maxItems: 1
+ minItems: 1
+ items:
+ - description: port reset
+ - description: optional external test bus reset
+
+ reset-names:
+ items:
+ - const: port
+ - const: test

patternProperties:
'phy@[0-9a-f]+':
@@ -66,6 +78,21 @@ required:
- '#size-cells'
- resets

+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: hisilicon,hi3798mv200-usb2-phy
+ then:
+ required:
+ - ranges
+ - reset-names
+ else:
+ properties:
+ ranges: false
+ reset-names: false
+
additionalProperties: false

examples:

--
2.43.0

2024-03-05 14:59:53

by Rob Herring (Arm)

Subject: Re: [PATCH v4 4/5] dt-bindings: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy

On Tue, 05 Mar 2024 10:19:49 +0800, Yang Xiwen wrote:
> Hi3798MV200 INNO USB2 PHY is attached directly to system bus. Add
> compatible "hisilicon,hi3798mv200-usb2-phy" for it. The ports of
> Hi3798MV200 INNO PHY has its own address space, so
>
> Signed-off-by: Yang Xiwen <[email protected]>
> ---
> .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 31 ++++++++++++++++++++--
> 1 file changed, 29 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2024-03-05 15:00:57

by Yang Xiwen

Subject: Re: [PATCH v4 4/5] dt-bindings: phy: hisi-inno-usb2: add compatible of hisilicon,hi3798mv200-usb2-phy

On 3/5/2024 10:58 PM, Rob Herring wrote:
> On Tue, 05 Mar 2024 10:19:49 +0800, Yang Xiwen wrote:
>> Hi3798MV200 INNO USB2 PHY is attached directly to system bus. Add
>> compatible "hisilicon,hi3798mv200-usb2-phy" for it. The ports of
>> Hi3798MV200 INNO PHY has its own address space, so


Somehow the commit msg is incomplete. Maybe the maintainer can help me
complete it.


Or i can fix it if there will be a newer version.


>>
>> Signed-off-by: Yang Xiwen <[email protected]>
>> ---
>> .../bindings/phy/hisilicon,inno-usb2-phy.yaml | 31 ++++++++++++++++++++--
>> 1 file changed, 29 insertions(+), 2 deletions(-)
>>
> Reviewed-by: Rob Herring <[email protected]>
>

--
Regards,
Yang Xiwen