2015-04-02 08:01:45

by Yoshihiro Shimoda

Subject: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
bit location is bit 8, not bits 1 and 0. It also says that the register
address offset of UGSTS is 0x88, not 0x90.
So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.

Signed-off-by: Yoshihiro Shimoda <[email protected]>
---
drivers/phy/phy-rcar-gen2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-rcar-gen2.c b/drivers/phy/phy-rcar-gen2.c
index 778276a..97d45f4 100644
--- a/drivers/phy/phy-rcar-gen2.c
+++ b/drivers/phy/phy-rcar-gen2.c
@@ -23,7 +23,7 @@
#define USBHS_LPSTS 0x02
#define USBHS_UGCTRL 0x80
#define USBHS_UGCTRL2 0x84
-#define USBHS_UGSTS 0x88 /* The manuals have 0x90 */
+#define USBHS_UGSTS 0x88 /* From technical update */

/* Low Power Status register (LPSTS) */
#define USBHS_LPSTS_SUSPM 0x4000
@@ -41,7 +41,7 @@
#define USBHS_UGCTRL2_USB0SEL_HS_USB 0x00000030

/* USB General status register (UGSTS) */
-#define USBHS_UGSTS_LOCK 0x00000300 /* The manuals have 0x3 */
+#define USBHS_UGSTS_LOCK 0x00000100 /* From technical update */

#define PHYS_PER_CHANNEL 2

--
1.9.1

2015-05-08 07:24:48

by Yoshihiro Shimoda

Subject: RE: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

Hi Kishon,

> Sent: Thursday, April 02, 2015 5:01 PM
>
> According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
> bit location is bit 8, not bits 1 and 0. It also says that the register
> address offset of UGSTS is 0x88, not 0x90.
> So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.
>
> Signed-off-by: Yoshihiro Shimoda <[email protected]>

Would you apply this patch to your repository?
I tried to apply this patch on the current fixes branch of linux-phy today,
this patch could be applied without any error.

Best regards,
Yoshihiro Shimoda

2015-05-08 07:41:37

by Kishon Vijay Abraham I

Subject: Re: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

On Friday 08 May 2015 12:54 PM, Yoshihiro Shimoda wrote:
> Hi Kishon,
>
>> Sent: Thursday, April 02, 2015 5:01 PM
>>
>> According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
>> bit location is bit 8, not bits 1 and 0. It also says that the register
>> address offset of UGSTS is 0x88, not 0x90.
>> So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.
>>
>> Signed-off-by: Yoshihiro Shimoda <[email protected]>
>
> Would you apply this patch to your repository?
> I tried to apply this patch on the current fixes branch of linux-phy today,
> this patch could be applied without any error.

applied now.

Thanks
Kishon
>
> Best regards,
> Yoshihiro Shimoda
>

2015-05-08 09:35:03

by Yoshihiro Shimoda

Subject: RE: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

Hi,

> On Friday 08 May 2015 12:54 PM, Yoshihiro Shimoda wrote:
> > Hi Kishon,
> >
> >> Sent: Thursday, April 02, 2015 5:01 PM
> >>
> >> According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK
> >> bit location is bit 8, not bits 1 and 0. It also says that the register
> >> address offset of UGSTS is 0x88, not 0x90.
> >> So, this patch fixes the USBHS_UGSTS_LOCK value and some comments.
> >>
> >> Signed-off-by: Yoshihiro Shimoda <[email protected]>
> >
> > Would you apply this patch to your repository?
> > I tried to apply this patch on the current fixes branch of linux-phy today,
> > this patch could be applied without any error.
>
> applied now.

Thank you very much for the prompt reply!

Best regards,
Yoshihiro Shimoda

> Thanks
> Kishon
> >
> > Best regards,
> > Yoshihiro Shimoda
> >