2023-10-02 15:36:52

by Rob Herring

Subject: Re: [PATCH v9 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

On Mon, Sep 18, 2023 at 02:41:09PM +0800, Billy Tsai wrote:
> From: Naresh Solanki <[email protected]>
>
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> $ref: fan-common.yaml#
> unevaluatedProperties: false
>
> Signed-off-by: Naresh Solanki <[email protected]>
> Signed-off-by: Billy Tsai <[email protected]>
> ---
> .../devicetree/bindings/hwmon/fan-common.yaml | 78 +++++++++++++++++++
> 1 file changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> new file mode 100644
> index 000000000000..2bd2f57fc9d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common Fan Properties
> +
> +maintainers:
> + - Naresh Solanki <[email protected]>
> + - Billy Tsai <[email protected]>
> +
> +properties:
> + max-rpm:
> + description:
> + Max RPM supported by fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 100000
> +
> + min-rpm:
> + description:
> + Min RPM supported by fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 1000
> +
> + pulses-per-revolution:
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 4
> +
> + tach-div:
> + description:
> + Divisor for the tach sampling clock, which determines the sensitivity of the tach pin.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + target-rpm:
> + description:
> + The default desired fan speed in RPM.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + fan-driving-mode:
> + description:
> + Select the driving mode of the fan.(DC, PWM and so on)
> + $ref: /schemas/types.yaml#/definitions/uint32

What value corresponds to what mode? I'd do strings instead. 'dc',
'pwm', etc.

> +
> + pwms:
> + description:
> + PWM provider.
> + maxItems: 1
> +
> + "#cooling-cells":
> + const: 2
> +
> + cooling-levels:
> + description: |

Don't need '|'

> + The control value which correspond to thermal cooling states.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> +
> + tach-ch:
> + description:
> + The tach channel used for the fan.
> + $ref: /schemas/types.yaml#/definitions/uint8-array
> +
> + label:
> + description:
> + Optional fan label
> +
> + fan-supply:
> + description:
> + Power supply for fan.
> +
> + reg:
> + maxItems: 1
> +
> +additionalProperties: true
> +
> +...
> --
> 2.25.1
>

2023-10-05 01:04:58

by Billy Tsai

Subject: Re: [PATCH v9 1/3] dt-bindings: hwmon: fan: Add fan binding to schema

>> From: Naresh Solanki <[email protected]>
>>
>> Add common fan properties bindings to a schema.
>>
>> Bindings for fan controllers can reference the common schema for the
>> fan
>>
>> child nodes:
>>
>> patternProperties:
>> "^fan@[0-2]":
>> type: object
>> $ref: fan-common.yaml#
>> unevaluatedProperties: false
>>
>> Signed-off-by: Naresh Solanki <[email protected]>
>> Signed-off-by: Billy Tsai <[email protected]>
>> ---
>> .../devicetree/bindings/hwmon/fan-common.yaml | 78 +++++++++++++++++++
>> 1 file changed, 78 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> new file mode 100644
>> index 000000000000..2bd2f57fc9d9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>> @@ -0,0 +1,78 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common Fan Properties
>> +
>> +maintainers:
>> + - Naresh Solanki <[email protected]>
>> + - Billy Tsai <[email protected]>
>> +
>> +properties:
>> + max-rpm:
>> + description:
>> + Max RPM supported by fan.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 100000
>> +
>> + min-rpm:
>> + description:
>> + Min RPM supported by fan.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 1000
>> +
>> + pulses-per-revolution:
>> + description:
>> + The number of pulse from fan sensor per revolution.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + maximum: 4
>> +
>> + tach-div:
>> + description:
>> + Divisor for the tach sampling clock, which determines the sensitivity of the tach pin.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + target-rpm:
>> + description:
>> + The default desired fan speed in RPM.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> + fan-driving-mode:
>> + description:
>> + Select the driving mode of the fan.(DC, PWM and so on)
>> + $ref: /schemas/types.yaml#/definitions/uint32

> What value corresponds to what mode? I'd do strings instead. 'dc',
> 'pwm', etc.


Ok, I will change the type to the string for next patch.

Thanks