2023-11-16 18:39:55

by Viken Dadhaniya

[permalink] [raw]
Subject: [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node

Add slimbus DT node to enable slimbus usecase on Bluetooth
for audio streaming and playback.

Based on requirement, client team can enable slimbus node
on target specific dt file.

Signed-off-by: Viken Dadhaniya <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 04bf85b0399a..fba352504f3f 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2528,6 +2528,31 @@
status = "disabled";
};

+ slimbam: dma-controller@3a84000 {
+ compatible = "qcom,bam-v1.7.0";
+ reg = <0x0 0x03a84000 0x0 0x20000>;
+ #dma-cells = <1>;
+ interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+ qcom,controlled-remotely;
+ num-channels = <31>;
+ qcom,ee = <1>;
+ qcom,num-ees = <2>;
+ iommus = <&apps_smmu 0x1826 0x0>;
+ status = "disabled";
+ };
+
+ slim_msm: slim-ngd@3ac0000 {
+ compatible = "qcom,slim-ngd-v1.5.0";
+ reg = <0x0 0x03ac0000 0x0 0x2c000>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&slimbam 3>, <&slimbam 4>;
+ dma-names = "rx", "tx";
+ iommus = <&apps_smmu 0x1826 0x0>;
+ status = "disabled";
+ };
+
lpass_hm: clock-controller@3c00000 {
compatible = "qcom,sc7280-lpasshm";
reg = <0 0x03c00000 0 0x28>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


2023-11-22 20:13:57

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node



On 11/16/23 19:39, Viken Dadhaniya wrote:
> Add slimbus DT node to enable slimbus usecase on Bluetooth
> for audio streaming and playback.
How can I test this?

>
> Based on requirement, client team can enable slimbus node
> on target specific dt file.
You can even enable it if you're not part of the client team!
This paragraph is a bit obvious for what it describes

>
> Signed-off-by: Viken Dadhaniya <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 04bf85b0399a..fba352504f3f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2528,6 +2528,31 @@
> status = "disabled";
> };
>
> + slimbam: dma-controller@3a84000 {
> + compatible = "qcom,bam-v1.7.0";
> + reg = <0x0 0x03a84000 0x0 0x20000>;
0x0 -> 0 to be consistent with other nodes

> + #dma-cells = <1>;
> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
interrupts should come after reg

> + qcom,controlled-remotely;
> + num-channels = <31>;
> + qcom,ee = <1>;
> + qcom,num-ees = <2>;
> + iommus = <&apps_smmu 0x1826 0x0>;
> + status = "disabled";
> + };
> +
> + slim_msm: slim-ngd@3ac0000 {
slim_msm -> slim

> + compatible = "qcom,slim-ngd-v1.5.0";
> + reg = <0x0 0x03ac0000 0x0 0x2c000>;
ditto

> + #address-cells = <1>;
> + #size-cells = <0>;
these two properties should go before the status property

> + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&slimbam 3>, <&slimbam 4>;
> + dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x1826 0x0>;
> + status = "disabled";
> + };
Konrad

2023-11-27 12:42:20

by Viken Dadhaniya

[permalink] [raw]
Subject: RE: [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node



> -----Original Message-----
> From: Konrad Dybcio <[email protected]>
> Sent: Thursday, November 23, 2023 1:43 AM
> To: Viken Dadhaniya (QUIC) <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7280: add slimbus DT node
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> On 11/16/23 19:39, Viken Dadhaniya wrote:
> > Add slimbus DT node to enable slimbus usecase on Bluetooth for audio
> > streaming and playback.
> How can I test this?

We can use RB3 board and validate playback over BT.

>
> >
> > Based on requirement, client team can enable slimbus node on target
> > specific dt file.
> You can even enable it if you're not part of the client team!
> This paragraph is a bit obvious for what it describes

Updated commit msg and uploaded v2.

>
> >
> > Signed-off-by: Viken Dadhaniya <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 04bf85b0399a..fba352504f3f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -2528,6 +2528,31 @@
> > status = "disabled";
> > };
> >
> > + slimbam: dma-controller@3a84000 {
> > + compatible = "qcom,bam-v1.7.0";
> > + reg = <0x0 0x03a84000 0x0 0x20000>;
> 0x0 -> 0 to be consistent with other nodes

Done.

>
> > + #dma-cells = <1>;
> > + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> interrupts should come after reg

Done.

>
> > + qcom,controlled-remotely;
> > + num-channels = <31>;
> > + qcom,ee = <1>;
> > + qcom,num-ees = <2>;
> > + iommus = <&apps_smmu 0x1826 0x0>;
> > + status = "disabled";
> > + };
> > +
> > + slim_msm: slim-ngd@3ac0000 {
> slim_msm -> slim

Done.

>
> > + compatible = "qcom,slim-ngd-v1.5.0";
> > + reg = <0x0 0x03ac0000 0x0 0x2c000>;
> ditto

Done.

>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> these two properties should go before the status property

Done.

>
> > + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> > + dmas = <&slimbam 3>, <&slimbam 4>;
> > + dma-names = "rx", "tx";
> > + iommus = <&apps_smmu 0x1826 0x0>;
> > + status = "disabled";
> > + };
> Konrad