2021-10-09 08:16:47

by Jiapeng Chong

Subject: [PATCH] qed: Fix missing error code in qed_slowpath_start()

From: chongjiapeng <[email protected]>

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'rc'.

Eliminate the follow smatch warning:

drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
warn: missing error code 'rc'.

Reported-by: Abaci Robot <[email protected]>
Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
Signed-off-by: chongjiapeng <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
index 5e7242304ee2..359ad859ae18 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
@@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
} else {
DP_NOTICE(cdev,
"Failed to acquire PTT for aRFS\n");
+ rc = -EINVAL;
goto err;
}
}
--
2.19.1.6.gb485710b

2021-10-09 12:51:53

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] qed: Fix missing error code in qed_slowpath_start()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Sat, 9 Oct 2021 16:09:26 +0800 you wrote:
> From: chongjiapeng <[email protected]>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
>
> Eliminate the follow smatch warning:
>
> [...]

Here is the summary with links:
- qed: Fix missing error code in qed_slowpath_start()
https://git.kernel.org/netdev/net/c/a5a14ea7b4e5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-10-11 07:03:32

by Alok Prasad

Subject: RE: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()

> -----Original Message-----
> From: Jiapeng Chong <[email protected]>
> Sent: 09 October 2021 13:39
> To: Ariel Elior <[email protected]>
> Cc: GR-everest-linux-l2 <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; linux-
> [email protected]; [email protected]; chongjiapeng
> <[email protected]>
> Subject: [EXT] [PATCH] qed: Fix missing error code in qed_slowpath_start()
>
> External Email
>
> ----------------------------------------------------------------------
> From: chongjiapeng <[email protected]>
>
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/qlogic/qed/qed_main.c:1298 qed_slowpath_start()
> warn: missing error code 'rc'.
>
> Reported-by: Abaci Robot <[email protected]>
> Fixes: d51e4af5c209 ("qed: aRFS infrastructure support")
> Signed-off-by: chongjiapeng <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
> b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 5e7242304ee2..359ad859ae18 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -1295,6 +1295,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
> } else {
> DP_NOTICE(cdev,
> "Failed to acquire PTT for aRFS\n");
> + rc = -EINVAL;
> goto err;
> }
> }
> --
> 2.19.1.6.gb485710b

Thanks!

Acked-by: Alok Prasad <[email protected]>