2024-04-02 09:00:28

by Akhil R

[permalink] [raw]
Subject: RE: [PATCH v6 3/5] crypto: tegra: Add Tegra Security Engine driver

> >
> > + .alg.skcipher.op.do_one_request = tegra_aes_do_one_req,
> > + .alg.skcipher.base = {
> > + .init = tegra_aes_cra_init,
> > + .exit = tegra_aes_cra_exit,
> > + .setkey = tegra_aes_setkey,
> > + .encrypt = tegra_aes_encrypt,
> > + .decrypt = tegra_aes_decrypt,
> > + .min_keysize = AES_MIN_KEY_SIZE,
> > + .max_keysize = AES_MAX_KEY_SIZE,
> > + .ivsize = AES_BLOCK_SIZE,
> > + .base = {
> > + .cra_name = "ofb(aes)",
> > + .cra_driver_name = "ofb-aes-tegra",
> > + .cra_priority = 500,
> > + .cra_flags = CRYPTO_ALG_TYPE_SKCIPHER |
> CRYPTO_ALG_ASYNC,
> > + .cra_blocksize = AES_BLOCK_SIZE,
> > + .cra_ctxsize = sizeof(struct tegra_aes_ctx),
> > + .cra_alignmask = 0xf,
> > + .cra_module = THIS_MODULE,
> > + },
> > + }
> > + }, {
>
> OFB no longer exists in the kernel. Please remove all traces of it from your driver.

Okay. Will remove and post a new version.

>
> Also please ensure that yuor driver passes the extra fuzz tests.

Yes. It does pass the extra fuzz tests.


Regards,
Akhil