2017-11-27 17:52:56

by Hartley Sweeten

[permalink] [raw]
Subject: RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote:
> On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
>> + const struct comedi_lrange *lrange;
>
> NAK. The following lines of source code allocate memory pointed to by 'lrange' and modify it, so 'const' is not appropriate here.

Ian,

Wonder if it's worth putting a comment about this in the code. This has come up a
couple times.

Regards,
Hartley
?&ן9?^;??{??u????L?sh?n?????~??M4?M{_???1? ????t?^?ێ7?}????f????m?l??ۣ?jנ???????????+?ƥRz