2020-03-27 03:02:38

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH v6 2/2] scsi: ufs: Do not rely on prefetched data


Can,

> We were setting bActiveICCLevel attribute for UFS device only once but
> type of this attribute has changed from persistent to volatile since
> UFS device specification v2.1. This attribute is set to the default
> value after power cycle or hardware reset event. It isn't safe to rely
> on prefetched data (only used for bActiveICCLevel attribute
> now). Hence this change removes the code related to data prefetching
> and set this parameter on every attempt to probe the UFS device.

Applied patch #2 to 5.7/scsi-queue. Awaiting Avri's feedback on patch
#1. Thanks!

--
Martin K. Petersen Oracle Linux Engineering


2020-03-27 07:50:00

by Avri Altman

[permalink] [raw]
Subject: RE: [PATCH v6 2/2] scsi: ufs: Do not rely on prefetched data



>
> Can,
>
> > We were setting bActiveICCLevel attribute for UFS device only once but
> > type of this attribute has changed from persistent to volatile since
> > UFS device specification v2.1. This attribute is set to the default
> > value after power cycle or hardware reset event. It isn't safe to rely
> > on prefetched data (only used for bActiveICCLevel attribute
> > now). Hence this change removes the code related to data prefetching
> > and set this parameter on every attempt to probe the UFS device.
>
> Applied patch #2 to 5.7/scsi-queue. Awaiting Avri's feedback on patch
> #1. Thanks!
It looks fine.
Thanks,
Avri

>
> --
> Martin K. Petersen Oracle Linux Engineering