2020-06-16 09:55:57

by Stanley Chu

Subject: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function

Fix build warning reported by kernel test robot:
Make ufs_mtk_wait_link_state() as static functon.

Warning:
>> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
>> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]

Signed-off-by: Stanley Chu <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/scsi/ufs/ufs-mediatek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 9a4432c9f7dc..ad929235c193 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -185,8 +185,8 @@ static void ufs_mtk_setup_ref_clk_wait_us(struct ufs_hba *hba,
host->ref_clk_ungating_wait_us = ungating_us;
}

-int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
- unsigned long max_wait_ms)
+static int ufs_mtk_wait_link_state(struct ufs_hba *hba, u32 state,
+ unsigned long max_wait_ms)
{
ktime_t timeout, time_checked;
u32 val;
--
2.18.0

2020-06-16 12:43:12

by Avri Altman

Subject: RE: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function

>
> Fix build warning reported by kernel test robot:
> Make ufs_mtk_wait_link_state() as static functon.
>
> Warning:
> >> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
> >> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]
>
> Signed-off-by: Stanley Chu <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

2020-06-20 05:11:00

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state as static function

On Tue, 16 Jun 2020 17:51:20 +0800, Stanley Chu wrote:

> Fix build warning reported by kernel test robot:
> Make ufs_mtk_wait_link_state() as static functon.
>
> Warning:
> >> drivers/scsi/ufs/ufs-mediatek.c:181:5: warning: no previous prototype
> >> for 'ufs_mtk_wait_link_state' [-Wmissing-prototypes]

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: ufs-mediatek: Make ufs_mtk_wait_link_state static
https://git.kernel.org/mkp/scsi/c/9a3cd470f8e3

--
Martin K. Petersen Oracle Linux Engineering