Hi all,
Commits
a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
16a9947646f7 ("iio: light: bu27008: add chip info")
ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
Thanks Stephen!
On 8/8/23 01:39, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
> 16a9947646f7 ("iio: light: bu27008: add chip info")
> ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
>
> are missing a Signed-off-by from their committer.
>
I am 99% sure I had SoB tags added in patches. Seems like they have been
lost in the action.
Jonathan, do you need me to respin patches or how do you think we should
fix this?
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
Hi Matti,
On Tue, 8 Aug 2023 09:26:08 +0300 Matti Vaittinen <[email protected]> wrote:
>
> Thanks Stephen!
>
> On 8/8/23 01:39, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commits
> >
> > a00cf70f16c9 ("iio: light: bd27008: Support BD27010 RGB")
> > 16a9947646f7 ("iio: light: bu27008: add chip info")
> > ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> >
> > are missing a Signed-off-by from their committer.
> >
>
> I am 99% sure I had SoB tags added in patches. Seems like they have been lost in the action.
The missing SOB is from the committer not the author.
--
Cheers,
Stephen Rothwell
> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: Dienstag, 12. September 2023 01:06
> To: Jonathan Cameron <[email protected]>
> Cc: Hennerich, Michael <[email protected]>; Cusco, Ana-
> Maria <[email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>; Linux Next Mailing List <linux-
> [email protected]>
> Subject: linux-next: Signed-off-by missing for commit in the iio tree
>
>
> Hi all,
>
> Commit
>
> 6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> Attenuator")
>
> is missing a Signed-off-by from its author.
Replied and added my Signed-off-by to the original patch.
Signed-off-by: Michael Hennerich <[email protected]>
>
> --
> Cheers,
> Stephen Rothwell
On Tue, 12 Sep 2023 06:37:17 +0000
"Hennerich, Michael" <[email protected]> wrote:
> > -----Original Message-----
> > From: Stephen Rothwell <[email protected]>
> > Sent: Dienstag, 12. September 2023 01:06
> > To: Jonathan Cameron <[email protected]>
> > Cc: Hennerich, Michael <[email protected]>; Cusco, Ana-
> > Maria <[email protected]>; Linux Kernel Mailing List <linux-
> > [email protected]>; Linux Next Mailing List <linux-
> > [email protected]>
> > Subject: linux-next: Signed-off-by missing for commit in the iio tree
> >
> >
> > Hi all,
> >
> > Commit
> >
> > 6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> > Attenuator")
> >
> > is missing a Signed-off-by from its author.
>
> Replied and added my Signed-off-by to the original patch.
>
> Signed-off-by: Michael Hennerich <[email protected]>
Hi Michael,
You missed and replied to the DT binding patch that followed this one.
I've taken above combined with that to be good enough confirmation that
you meant this one and added the sign off. Great if you could confirm
that for the record though!
+CC linux-iio to keep the two discussions together.
+CC Krzysztof who asked about that rather odd looking SoB as well.
Jonathan
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> -----Original Message-----
> From: Jonathan Cameron <[email protected]>
> Sent: Dienstag, 12. September 2023 11:20
> To: Hennerich, Michael <[email protected]>
> Cc: Stephen Rothwell <[email protected]>; Cusco, Ana-Maria <Ana-
> [email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>; Linux Next Mailing List <linux-
> [email protected]>; [email protected]; Krzysztof Kozlowski
> <[email protected]>
> Subject: Re: linux-next: Signed-off-by missing for commit in the iio tree
>
> [External]
>
> On Tue, 12 Sep 2023 06:37:17 +0000
> "Hennerich, Michael" <[email protected]> wrote:
>
> > > -----Original Message-----
> > > From: Stephen Rothwell <[email protected]>
> > > Sent: Dienstag, 12. September 2023 01:06
> > > To: Jonathan Cameron <[email protected]>
> > > Cc: Hennerich, Michael <[email protected]>; Cusco, Ana-
> > > Maria <[email protected]>; Linux Kernel Mailing List
> > > <linux- [email protected]>; Linux Next Mailing List <linux-
> > > [email protected]>
> > > Subject: linux-next: Signed-off-by missing for commit in the iio
> > > tree
> > >
> > >
> > > Hi all,
> > >
> > > Commit
> > >
> > > 6ed193ca529e ("iio: amplifiers: hmc425a: Add Support HMC540S 4-bit
> > > Attenuator")
> > >
> > > is missing a Signed-off-by from its author.
> >
> > Replied and added my Signed-off-by to the original patch.
> >
> > Signed-off-by: Michael Hennerich <[email protected]>
>
> Hi Michael,
>
> You missed and replied to the DT binding patch that followed this one.
> I've taken above combined with that to be good enough confirmation that
> you meant this one and added the sign off. Great if you could confirm that
> for the record though!
Sorry - my fault.
The Signed-off-by tag should have been for patch "iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator"
Regards,
Michael
>
> +CC linux-iio to keep the two discussions together.
> +CC Krzysztof who asked about that rather odd looking SoB as well.
>
> Jonathan
>
> >
> > >
> > > --
> > > Cheers,
> > > Stephen Rothwell