2018-12-14 08:29:34

by Fabrizio Castro

Subject: [PATCH] usb: renesas_usbhs: add support for RZ/G2E

HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
the PLL reset by the UGCTRL register like R-Car E3, therefore add
r8a774c0 support in a similar fashion to what was done for the
r8a77990.

Signed-off-by: Fabrizio Castro <[email protected]>
---
drivers/usb/renesas_usbhs/common.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 2ff7991..249fbee 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -540,6 +540,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
*/
static const struct of_device_id usbhs_of_match[] = {
{
+ .compatible = "renesas,usbhs-r8a774c0",
+ .data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
+ },
+ {
.compatible = "renesas,usbhs-r8a7790",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
--
2.7.4

2018-12-14 09:16:10

by Yoshihiro Shimoda

Subject: RE: [PATCH] usb: renesas_usbhs: add support for RZ/G2E

Hi Fabrizio,

> From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:27 PM
>
> HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
> one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
> the PLL reset by the UGCTRL register like R-Car E3, therefore add
> r8a774c0 support in a similar fashion to what was done for the
> r8a77990.
>
> Signed-off-by: Fabrizio Castro <[email protected]>

Thank you for the patch!

Acked-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

> ---
> drivers/usb/renesas_usbhs/common.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 2ff7991..249fbee 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -540,6 +540,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
> */
> static const struct of_device_id usbhs_of_match[] = {
> {
> + .compatible = "renesas,usbhs-r8a774c0",
> + .data = (void *)USBHS_TYPE_RCAR_GEN3_WITH_PLL,
> + },
> + {
> .compatible = "renesas,usbhs-r8a7790",
> .data = (void *)USBHS_TYPE_RCAR_GEN2,
> },
> --
> 2.7.4

2018-12-15 15:18:48

by Simon Horman

Subject: Re: [PATCH] usb: renesas_usbhs: add support for RZ/G2E

On Fri, Dec 14, 2018 at 08:27:03AM +0000, Fabrizio Castro wrote:
> HS-USB found in RZ/G2E (a.k.a. r8a774c0) is very similar to the
> one found in R-Car E3 (a.k.a. r8a77990), as it needs to release
> the PLL reset by the UGCTRL register like R-Car E3, therefore add
> r8a774c0 support in a similar fashion to what was done for the
> r8a77990.
>
> Signed-off-by: Fabrizio Castro <[email protected]>

Reviewed-by: Simon Horman <[email protected]>