2020-07-22 03:26:11

by Gustavo A. R. Silva

Subject: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Reviewed-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
Changes in v2:
- Update URL. Use proper URL to Linux v5.7 documentation.
- Add Geert's Reviewed-by tag.
- Update changelog text.

drivers/pci/controller/pci-rcar-gen2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
index 326171cb1a97..2ec7093a7588 100644
--- a/drivers/pci/controller/pci-rcar-gen2.c
+++ b/drivers/pci/controller/pci-rcar-gen2.c
@@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
pr_warn("unknown window size %ld - defaulting to 256M\n",
priv->window_size);
priv->window_size = SZ_256M;
- /* fall-through */
+ fallthrough;
case SZ_256M:
val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
break;
--
2.27.0

2020-07-31 09:10:06

by Yoshihiro Shimoda

Subject: RE: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

Hi,

> From: Gustavo A. R. Silva, Sent: Wednesday, July 22, 2020 12:29 PM
>
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1]
> https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

2020-09-07 16:34:45

by Lorenzo Pieralisi

Subject: Re: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

On Tue, Jul 21, 2020 at 10:28:51PM -0500, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
>
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> Changes in v2:
> - Update URL. Use proper URL to Linux v5.7 documentation.
> - Add Geert's Reviewed-by tag.
> - Update changelog text.
>
> drivers/pci/controller/pci-rcar-gen2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/rcar, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/pci-rcar-gen2.c b/drivers/pci/controller/pci-rcar-gen2.c
> index 326171cb1a97..2ec7093a7588 100644
> --- a/drivers/pci/controller/pci-rcar-gen2.c
> +++ b/drivers/pci/controller/pci-rcar-gen2.c
> @@ -228,7 +228,7 @@ static int rcar_pci_setup(int nr, struct pci_sys_data *sys)
> pr_warn("unknown window size %ld - defaulting to 256M\n",
> priv->window_size);
> priv->window_size = SZ_256M;
> - /* fall-through */
> + fallthrough;
> case SZ_256M:
> val |= RCAR_USBCTR_PCIAHB_WIN1_256M;
> break;
> --
> 2.27.0
>