2020-10-23 16:37:06

by Prabhakar Mahadev Lad

Subject: [PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

Drop unused members dev and base from struct rcar_pcie_host.

Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/pci/controller/pcie-rcar-host.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index cdc0963f154e..4d1c4b24e537 100644
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -50,9 +50,7 @@ static inline struct rcar_msi *to_rcar_msi(struct msi_controller *chip)
/* Structure representing the PCIe interface */
struct rcar_pcie_host {
struct rcar_pcie pcie;
- struct device *dev;
struct phy *phy;
- void __iomem *base;
struct clk *bus_clk;
struct rcar_msi msi;
int (*phy_init_fn)(struct rcar_pcie_host *host);
--
2.17.1

2020-10-28 07:24:49

by Yoshihiro Shimoda

Subject: RE: [PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

Hi Lad,

> From: Lad Prabhakar, Sent: Saturday, October 24, 2020 1:20 AM
>
> Drop unused members dev and base from struct rcar_pcie_host.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

> ---
> drivers/pci/controller/pcie-rcar-host.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
> index cdc0963f154e..4d1c4b24e537 100644
> --- a/drivers/pci/controller/pcie-rcar-host.c
> +++ b/drivers/pci/controller/pcie-rcar-host.c
> @@ -50,9 +50,7 @@ static inline struct rcar_msi *to_rcar_msi(struct msi_controller *chip)
> /* Structure representing the PCIe interface */
> struct rcar_pcie_host {
> struct rcar_pcie pcie;
> - struct device *dev;
> struct phy *phy;
> - void __iomem *base;
> struct clk *bus_clk;
> struct rcar_msi msi;
> int (*phy_init_fn)(struct rcar_pcie_host *host);
> --
> 2.17.1

2020-10-29 13:46:39

by Geert Uytterhoeven

Subject: Re: [PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

On Fri, Oct 23, 2020 at 6:36 PM Lad Prabhakar
<[email protected]> wrote:
> Drop unused members dev and base from struct rcar_pcie_host.
>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-11-20 17:03:17

by Lorenzo Pieralisi

Subject: Re: [PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

On Fri, 23 Oct 2020 17:20:08 +0100, Lad Prabhakar wrote:
> Drop unused members dev and base from struct rcar_pcie_host.

Applied to pci/rcar, thanks!

[1/1] PCI: rcar: Drop unused members from struct rcar_pcie_host
https://git.kernel.org/lpieralisi/pci/c/6e8e137abe

Thanks,
Lorenzo