The force parameter in irq_set_affinity_deactivated() is not used,
get rid of it.
Fixes: baedb87d1b53 ("genirq/affinity: Handle affinity setting on inactive interrupts correctly")
Signed-off-by: Angus Chen <[email protected]>
---
kernel/irq/manage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 40fe7806cc8c..5b7cf28df290 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -321,7 +321,7 @@ static int irq_try_set_affinity(struct irq_data *data,
}
static bool irq_set_affinity_deactivated(struct irq_data *data,
- const struct cpumask *mask, bool force)
+ const struct cpumask *mask)
{
struct irq_desc *desc = irq_data_to_desc(data);
@@ -354,7 +354,7 @@ int irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask,
if (!chip || !chip->irq_set_affinity)
return -EINVAL;
- if (irq_set_affinity_deactivated(data, mask, force))
+ if (irq_set_affinity_deactivated(data, mask))
return 0;
if (irq_can_move_pcntxt(data) && !irqd_is_setaffinity_pending(data)) {
--
2.25.1
On Fri, Oct 07 2022 at 18:32, Angus Chen wrote:
> The force parameter in irq_set_affinity_deactivated() is not used,
> get rid of it.
Correct.
> Fixes: baedb87d1b53 ("genirq/affinity: Handle affinity setting on
> inactive interrupts correctly")
What does this fix? An unused argument is neither a bug nor a
problem. Removing it is a cleanup nothing else.
Thanks,
tglx
Hi tglx.
> -----Original Message-----
> From: Thomas Gleixner <[email protected]>
> Sent: Saturday, November 12, 2022 2:11 AM
> To: Angus Chen <[email protected]>
> Cc: [email protected]; Angus Chen <[email protected]>
> Subject: Re: [PATCH] genirq: Remove unused parameter force of
> irq_set_affinity_deactivated()
>
> On Fri, Oct 07 2022 at 18:32, Angus Chen wrote:
> > The force parameter in irq_set_affinity_deactivated() is not used,
> > get rid of it.
>
> Correct.
>
> > Fixes: baedb87d1b53 ("genirq/affinity: Handle affinity setting on
> > inactive interrupts correctly")
>
> What does this fix? An unused argument is neither a bug nor a
> problem. Removing it is a cleanup nothing else.
>
Thank you for your reply.
I almost forget this patch because it just a cleanup.
I thought maybe it is too simple to submit,
so it be ignored by maintainer.
Can I send a v2 to modify the git log ?
Thanks.
> Thanks,
>
> tglx
The following commit has been merged into the irq/core branch of tip:
Commit-ID: fd19ce77993a49f3afc56bb4cae7eafb1ec69e0c
Gitweb: https://git.kernel.org/tip/fd19ce77993a49f3afc56bb4cae7eafb1ec69e0c
Author: Angus Chen <[email protected]>
AuthorDate: Fri, 07 Oct 2022 18:32:36 +08:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Thu, 17 Nov 2022 14:00:55 +01:00
genirq: Remove unused argument force of irq_set_affinity_deactivated()
The force parameter in irq_set_affinity_deactivated() is not used,
get rid of it.
Signed-off-by: Angus Chen <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/irq/manage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 40fe780..5b7cf28 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -321,7 +321,7 @@ static int irq_try_set_affinity(struct irq_data *data,
}
static bool irq_set_affinity_deactivated(struct irq_data *data,
- const struct cpumask *mask, bool force)
+ const struct cpumask *mask)
{
struct irq_desc *desc = irq_data_to_desc(data);
@@ -354,7 +354,7 @@ int irq_set_affinity_locked(struct irq_data *data, const struct cpumask *mask,
if (!chip || !chip->irq_set_affinity)
return -EINVAL;
- if (irq_set_affinity_deactivated(data, mask, force))
+ if (irq_set_affinity_deactivated(data, mask))
return 0;
if (irq_can_move_pcntxt(data) && !irqd_is_setaffinity_pending(data)) {