Since commit b2cb2ae22278f1918f7526b89760ee00b4a81393 ("mfd: axp20x:
Generalise handling without interrupt"), interrupt info part for the
AXP15060 PMIC is not needed anymore for Statfive Visionfive 2 board.
And this would cause kernel to try to enable interrupt line 0, which is
not expected. So delete this part from device tree.
Cc: [email protected]
Fixes: b2cb2ae22278 ("mfd: axp20x: Generalise handling without interrupt")
Reported-by: Bo Gan <[email protected]>
Signed-off-by: Shengyu Qu <[email protected]>
---
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
index b89e9791efa7..6bebabe3fa37 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
@@ -189,9 +189,6 @@ &i2c5 {
axp15060: pmic@36 {
compatible = "x-powers,axp15060";
reg = <0x36>;
- interrupts = <0>;
- interrupt-controller;
- #interrupt-cells = <1>;
regulators {
vcc_3v3: dcdc1 {
--
2.39.2
On Wed, Mar 06, 2024 at 01:11:50AM +0800, Shengyu Qu wrote:
> Since commit b2cb2ae22278f1918f7526b89760ee00b4a81393 ("mfd: axp20x:
> Generalise handling without interrupt"), interrupt info part for the
> AXP15060 PMIC is not needed anymore for Statfive Visionfive 2 board.
> And this would cause kernel to try to enable interrupt line 0, which is
> not expected. So delete this part from device tree.
interrupt-controller/#interrupt-cells are required properties, you can't
delete them. If you ran dtbs_check you'd see that it complains about
this patch.
If you just remove the interrupts property, what happens?
> Cc: [email protected]
> Fixes: b2cb2ae22278 ("mfd: axp20x: Generalise handling without interrupt")
This Fixes tag cannot be right, a dts patch cannot fix a driver. The dts
patch that incorrectly said this used interrupt 0 is what should be in the
Fixes tag.
Thanks,
Conor.
> Reported-by: Bo Gan <[email protected]>
Closes: https://lore.kernel.org/linux-riscv/[email protected]/
> Signed-off-by: Shengyu Qu <[email protected]>
> ---
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> index b89e9791efa7..6bebabe3fa37 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> @@ -189,9 +189,6 @@ &i2c5 {
> axp15060: pmic@36 {
> compatible = "x-powers,axp15060";
> reg = <0x36>;
> - interrupts = <0>;
> - interrupt-controller;
> - #interrupt-cells = <1>;
>
> regulators {
> vcc_3v3: dcdc1 {
> --
> 2.39.2
>
Hi Conor,
Thanks for reply. I’m sorry for this, but my distro’s dt-schema
is too old to run dtbs-check. Will fix in next version.
Best regards
> 在 2024年3月6日，03:41，Conor Dooley <[email protected]> 写道：
>
> On Wed, Mar 06, 2024 at 01:11:50AM +0800, Shengyu Qu wrote:
>> Since commit b2cb2ae22278f1918f7526b89760ee00b4a81393 ("mfd: axp20x:
>> Generalise handling without interrupt"), interrupt info part for the
>> AXP15060 PMIC is not needed anymore for Statfive Visionfive 2 board.
>> And this would cause kernel to try to enable interrupt line 0, which is
>> not expected. So delete this part from device tree.
>
> interrupt-controller/#interrupt-cells are required properties, you can't
> delete them. If you ran dtbs_check you'd see that it complains about
> this patch.
>
> If you just remove the interrupts property, what happens?
>
>> Cc: [email protected]
>> Fixes: b2cb2ae22278 ("mfd: axp20x: Generalise handling without interrupt")
>
> This Fixes tag cannot be right, a dts patch cannot fix a driver. The dts
> patch that incorrectly said this used interrupt 0 is what should be in the
> Fixes tag.
>
> Thanks,
> Conor.
>
>> Reported-by: Bo Gan <[email protected]>
>
> Closes: https://lore.kernel.org/linux-riscv/[email protected]/
>
>> Signed-off-by: Shengyu Qu <[email protected]>
>> ---
>> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> index b89e9791efa7..6bebabe3fa37 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> @@ -189,9 +189,6 @@ &i2c5 {
>> axp15060: pmic@36 {
>> compatible = "x-powers,axp15060";
>> reg = <0x36>;
>> - interrupts = <0>;
>> - interrupt-controller;
>> - #interrupt-cells = <1>;
>>
>> regulators {
>> vcc_3v3: dcdc1 {
>> --
>> 2.39.2
>>