2023-04-17 09:07:28

by Shengyu Qu

[permalink] [raw]
Subject: [PATCH v2 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant

The X-Powers AXP15060 is a PMIC seen on Starfive Visionfive 2 board. Add
relative compatible item and CPUSLDO support for it.

Changes since v1:
- Move cpusldo before drivevbus (Krzysztof Kozlowski)

Signed-off-by: Shengyu Qu <[email protected]>
---
Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
index 8eeb5b387430..33c1a7020fac 100644
--- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
+++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
@@ -86,6 +86,7 @@ properties:
- x-powers,axp806
- x-powers,axp809
- x-powers,axp813
+ - x-powers,axp15060
- items:
- const: x-powers,axp228
- const: x-powers,axp221
@@ -254,7 +255,7 @@ properties:
Defines the work frequency of DC-DC in kHz.

patternProperties:
- "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|drivevbus|dc5ldo)$":
+ "^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$":
$ref: /schemas/regulator/regulator.yaml#
type: object
unevaluatedProperties: false
--
2.25.1


2023-04-18 16:17:54

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant

On 17/04/2023 11:05, Shengyu Qu wrote:
> The X-Powers AXP15060 is a PMIC seen on Starfive Visionfive 2 board. Add
> relative compatible item and CPUSLDO support for it.
>
> Changes since v1:
> - Move cpusldo before drivevbus (Krzysztof Kozlowski)
>

Changelog usually goes after ---, especially for such trivial stuff.

Reviewed-by: Krzysztof Kozlowski <[email protected]>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tools like b4 can help
here. However, there's no need to repost patches *only* to add the tags.
The upstream maintainer will do that for acks received on the version
they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof

2023-04-24 12:14:14

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant

On Mon, 17 Apr 2023, Shengyu Qu wrote:

> The X-Powers AXP15060 is a PMIC seen on Starfive Visionfive 2 board. Add
> relative compatible item and CPUSLDO support for it.
>
> Changes since v1:
> - Move cpusldo before drivevbus (Krzysztof Kozlowski)
>
> Signed-off-by: Shengyu Qu <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]

2023-04-24 16:03:38

by Shengyu Qu

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: x-powers,axp152: Document the AXP15060 variant

Hi Lee,

V3 already sent [1] few days ago, with patch 1 modified, please change
to v3.

Shengyu

---

I didn't use reply all for the previous mail, so I sent it again.

---

[1]
https://lore.kernel.org/all/TY3P286MB261177CF7AA2959BD9517DA998609@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM/T/#m0d1b78a5f561c4192cc2e9d409ba552ae60af986


> On Mon, 17 Apr 2023, Shengyu Qu wrote:
>
>> The X-Powers AXP15060 is a PMIC seen on Starfive Visionfive 2 board. Add
>> relative compatible item and CPUSLDO support for it.
>>
>> Changes since v1:
>> - Move cpusldo before drivevbus (Krzysztof Kozlowski)
>>
>> Signed-off-by: Shengyu Qu <[email protected]>
>> ---
>> Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
> Applied, thanks
>