2020-02-18 19:34:02

by Corentin LABBE

Subject: [PATCH 14/20] usb: gadget: renesas_usb3: remove useless cast for driver.name

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index c5c3c14df67a..42ae99ad9b25 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -2906,7 +2906,7 @@ static struct platform_driver renesas_usb3_driver = {
.probe = renesas_usb3_probe,
.remove = renesas_usb3_remove,
.driver = {
- .name = (char *)udc_name,
+ .name = udc_name,
.pm = &renesas_usb3_pm_ops,
.of_match_table = of_match_ptr(usb3_of_match),
},
--
2.24.1

2020-02-19 00:37:40

by Yoshihiro Shimoda

Subject: RE: [PATCH 14/20] usb: gadget: renesas_usb3: remove useless cast for driver.name

Hi,

> From: Corentin Labbe, Sent: Wednesday, February 19, 2020 4:33 AM
>
> device_driver name is const char pointer, so it not useful to cast
> udc_name (which is already const char).
>
> Signed-off-by: Corentin Labbe <[email protected]>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda