2020-02-18 19:34:30

by Corentin LABBE

Subject: [PATCH 13/20] usb: gadget: r8a66597-udc: remove useless cast for driver.name

device_driver name is const char pointer, so it not useful to cast
udc_name (which is already const char).

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/usb/gadget/udc/r8a66597-udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c
index 582a16165ea9..537094b485bf 100644
--- a/drivers/usb/gadget/udc/r8a66597-udc.c
+++ b/drivers/usb/gadget/udc/r8a66597-udc.c
@@ -1968,7 +1968,7 @@ static int r8a66597_probe(struct platform_device *pdev)
static struct platform_driver r8a66597_driver = {
.remove = r8a66597_remove,
.driver = {
- .name = (char *) udc_name,
+ .name = udc_name,
},
};

--
2.24.1

2020-02-19 00:44:42

by Yoshihiro Shimoda

Subject: RE: [PATCH 13/20] usb: gadget: r8a66597-udc: remove useless cast for driver.name

Hi,

> From: Corentin Labbe, Sent: Wednesday, February 19, 2020 4:33 AM
>
> device_driver name is const char pointer, so it not useful to cast
> udc_name (which is already const char).
>
> Signed-off-by: Corentin Labbe <[email protected]>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda