2020-03-25 06:19:04

by Yoshihiro Shimoda

[permalink] [raw]
Subject: [PATCH 0/2] dt-bindings: phy: add r8a77961 support

This patch adds USBPHY 2.0/3.0 devices support for r8a77961
(R-Car M3-W+).

Yoshihiro Shimoda (2):
dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961 support
dt-bindings: phy: rcar-gen3-phy-usb3: add r8a77961 support

Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++
2 files changed, 4 insertions(+)

--
2.7.4


2020-03-25 06:19:07

by Yoshihiro Shimoda

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961 support

This patch adds support for r8a77961 (R-Car M3-W+).

Signed-off-by: Yoshihiro Shimoda <[email protected]>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
index 7734b21..0a65901 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
@@ -18,6 +18,8 @@ Required properties:
SoC.
"renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796
SoC.
+ "renesas,usb2-phy-r8a77961" if the device is a part of an
+ R8A77961 SoC.
"renesas,usb2-phy-r8a77965" if the device is a part of an
R8A77965 SoC.
"renesas,usb2-phy-r8a77990" if the device is a part of an
--
2.7.4

2020-03-25 06:20:24

by Yoshihiro Shimoda

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: phy: rcar-gen3-phy-usb3: add r8a77961 support

This patch adds support for r8a77961 (R-Car M3-W+).

Signed-off-by: Yoshihiro Shimoda <[email protected]>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
index 0fe433b..99c17c6 100644
--- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
+++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
@@ -15,6 +15,8 @@ Required properties:
SoC.
"renesas,r8a7796-usb3-phy" if the device is a part of an R8A7796
SoC.
+ "renesas,r8a77961-usb3-phy" if the device is a part of an
+ R8A77961 SoC.
"renesas,r8a77965-usb3-phy" if the device is a part of an
R8A77965 SoC.
"renesas,rcar-gen3-usb3-phy" for a generic R-Car Gen3 or RZ/G2
--
2.7.4

2020-03-25 13:07:58

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961 support

Hi Shimoda-san,

On Wed, Mar 25, 2020 at 7:18 AM Yoshihiro Shimoda
<[email protected]> wrote:
> This patch adds support for r8a77961 (R-Car M3-W+).
>
> Signed-off-by: Yoshihiro Shimoda <[email protected]>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> @@ -18,6 +18,8 @@ Required properties:
> SoC.
> "renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796

While at it, you may want to update "r8A7796 SoC" to "r8A77960 SoC", to
avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

Note that rebasing this patch on top of your "[PATCH v2] dt-bindings:
phy: renesas: usb2-phy: convert bindings to json-schema"
(https://lore.kernel.org/linux-devicetree/1572592763-12396-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
would avoid that, too.

> SoC.
> + "renesas,usb2-phy-r8a77961" if the device is a part of an
> + R8A77961 SoC.
> "renesas,usb2-phy-r8a77965" if the device is a part of an
> R8A77965 SoC.
> "renesas,usb2-phy-r8a77990" if the device is a part of an

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-03-25 13:10:15

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: phy: rcar-gen3-phy-usb3: add r8a77961 support

Hi Shimoda-san,

On Wed, Mar 25, 2020 at 7:19 AM Yoshihiro Shimoda
<[email protected]> wrote:
> This patch adds support for r8a77961 (R-Car M3-W+).
>
> Signed-off-by: Yoshihiro Shimoda <[email protected]>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
> @@ -15,6 +15,8 @@ Required properties:
> SoC.
> "renesas,r8a7796-usb3-phy" if the device is a part of an R8A7796
> SoC.
> + "renesas,r8a77961-usb3-phy" if the device is a part of an
> + R8A77961 SoC.
> "renesas,r8a77965-usb3-phy" if the device is a part of an
> R8A77965 SoC.
> "renesas,rcar-gen3-usb3-phy" for a generic R-Car Gen3 or RZ/G2

Reviewed-by: Geert Uytterhoeven <[email protected]>

Likewise, a rebase on top of "[v2] dt-bindings: phy: renesas: usb3-phy:
convert bindings to json-schema"
(https://lore.kernel.org/linux-devicetree/1572592771-12444-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
would be nice.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-03-26 02:17:07

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: [PATCH 1/2] dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961 support

Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 10:07 PM
<snip>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > @@ -18,6 +18,8 @@ Required properties:
> > SoC.
> > "renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796
>
> While at it, you may want to update "r8A7796 SoC" to "r8A77960 SoC", to
> avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).
>
> Note that rebasing this patch on top of your "[PATCH v2] dt-bindings:
> phy: renesas: usb2-phy: convert bindings to json-schema"
> (https://lore.kernel.org/linux-devicetree/1572592763-12396-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
> would avoid that, too.

I completely forgot about the patch I made...
So, I'll rebase this patch on the .yaml.


> > SoC.
> > + "renesas,usb2-phy-r8a77961" if the device is a part of an
> > + R8A77961 SoC.
> > "renesas,usb2-phy-r8a77965" if the device is a part of an
> > R8A77965 SoC.
> > "renesas,usb2-phy-r8a77990" if the device is a part of an
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Thanks!

Best regards,
Yoshihiro Shimoda

> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

2020-03-26 02:20:32

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: [PATCH 2/2] dt-bindings: phy: rcar-gen3-phy-usb3: add r8a77961 support

Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 10:09 PM
<snip>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
> > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt
> > @@ -15,6 +15,8 @@ Required properties:
> > SoC.
> > "renesas,r8a7796-usb3-phy" if the device is a part of an R8A7796
> > SoC.
> > + "renesas,r8a77961-usb3-phy" if the device is a part of an
> > + R8A77961 SoC.
> > "renesas,r8a77965-usb3-phy" if the device is a part of an
> > R8A77965 SoC.
> > "renesas,rcar-gen3-usb3-phy" for a generic R-Car Gen3 or RZ/G2
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Likewise, a rebase on top of "[v2] dt-bindings: phy: renesas: usb3-phy:
> convert bindings to json-schema"
> (https://lore.kernel.org/linux-devicetree/1572592771-12444-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
> would be nice.

I agreed. I'll rebase it.

Best regards,
Yoshihiro Shimoda