2022-07-22 08:43:10

by Yuji Ishikawa

[permalink] [raw]
Subject: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index dd36acc87..a2e2bd719 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2796,12 +2796,14 @@ F: Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.yaml
F: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
F: Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
F: Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.yaml
+F: Documentation/devicetree/bindings/soc/visconti/
F: Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
F: arch/arm64/boot/dts/toshiba/
F: drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
F: drivers/gpio/gpio-visconti.c
F: drivers/pci/controller/dwc/pcie-visconti.c
F: drivers/pinctrl/visconti/
+F: drivers/soc/visconti/
F: drivers/watchdog/visconti_wdt.c
N: visconti

--
2.17.1



2022-07-25 12:50:02

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

On Fri, Jul 22, 2022 at 05:28:57PM +0900, Yuji Ishikawa wrote:
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)

No changelog text?

No signed-off-by?

Are you sure that checkpatch passed this patch?

greg k-h

2022-07-26 06:55:54

by Yuji Ishikawa

[permalink] [raw]
Subject: RE: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

Sorry for this patch not being well formatted.

I'll add change log and the signed-off-by tag.
I should have checked patches with checkpatch.pl as well as testing sources with --file option.

Regards,
Yuji

> -----Original Message-----
> From: Greg KH <[email protected]>
> Sent: Monday, July 25, 2022 9:47 PM
> To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開)
> <[email protected]>
> Cc: Rob Herring <[email protected]>; Hans Verkuil <[email protected]>;
> iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT)
> <[email protected]>; Jonathan Corbet <[email protected]>;
> Sumit Semwal <[email protected]>; Christian König
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti
> DNN image processing accelerator
>
> On Fri, Jul 22, 2022 at 05:28:57PM +0900, Yuji Ishikawa wrote:
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
>
> No changelog text?
>
> No signed-off-by?
>
> Are you sure that checkpatch passed this patch?
>
> greg k-h

2022-07-28 09:13:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 4/5] MAINTAINERS: Add entries for Toshiba Visconti DNN image processing accelerator

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jul 26, 2022 at 06:10:40AM +0000, [email protected] wrote:
> Sorry for this patch not being well formatted.
>
> I'll add change log and the signed-off-by tag.
> I should have checked patches with checkpatch.pl as well as testing sources with --file option.

Just a normal call to checkpatch will work, no need for the --file
option.

Also for new stuff, please use the --strict to see more things that you
might also want to fix up.

For future versions, also please cc: me on this series.

thanks,

greg k-h