2021-09-16 07:39:29

by Cai,Huoqing

Subject: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
index d046e33b8a29..66fc8be34bb7 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
@@ -171,10 +171,9 @@ static int visconti_eth_clock_probe(struct platform_device *pdev,
int err;

dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk");
- if (IS_ERR(dwmac->phy_ref_clk)) {
- dev_err(&pdev->dev, "phy_ref_clk clock not found.\n");
- return PTR_ERR(dwmac->phy_ref_clk);
- }
+ if (IS_ERR(dwmac->phy_ref_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->phy_ref_clk),
+ "phy_ref_clk clock not found.\n");

err = clk_prepare_enable(dwmac->phy_ref_clk);
if (err < 0) {
--
2.25.1

2021-09-16 13:55:43

by Nobuhiro Iwamatsu

Subject: RE: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

Hi,

> -----Original Message-----
> From: Cai Huoqing [mailto:[email protected]]
> Sent: Thursday, September 16, 2021 4:38 PM
> To: [email protected]
> Cc: Giuseppe Cavallaro <[email protected]>; Alexandre Torgue <[email protected]>; Jose Abreu
> <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Maxime Coquelin
> <[email protected]>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]
> Subject: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()
>
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> And using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Acked-by: Nobuhiro Iwamatsu <[email protected]>

>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> index d046e33b8a29..66fc8be34bb7 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
> @@ -171,10 +171,9 @@ static int visconti_eth_clock_probe(struct platform_device *pdev,
> int err;
>
> dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk");
> - if (IS_ERR(dwmac->phy_ref_clk)) {
> - dev_err(&pdev->dev, "phy_ref_clk clock not found.\n");
> - return PTR_ERR(dwmac->phy_ref_clk);
> - }
> + if (IS_ERR(dwmac->phy_ref_clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->phy_ref_clk),
> + "phy_ref_clk clock not found.\n");
>
> err = clk_prepare_enable(dwmac->phy_ref_clk);
> if (err < 0) {
> --
> 2.25.1

Best regards,
Nobuhiro

2021-09-17 15:07:55

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Thu, 16 Sep 2021 15:37:36 +0800 you wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> And using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <[email protected]>
>
> [...]

Here is the summary with links:
- net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()
https://git.kernel.org/netdev/net-next/c/b20b54fb00a8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html