2022-01-07 18:33:32

by Nathan Chancellor

Subject: [PATCH] clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup()

Clang warns:

drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (ctx->clk_data.hws && id)
~~~~~~~~~~~~~~^~~ ~~
1 warning generated.

This array cannot be NULL if ctx is not NULL, which is allocated in
visconti_init_pll(), so just remove the check, which matches other clk
drivers.

Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1564
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
---
drivers/clk/visconti/pll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c
index 3b6e88bb73d5..a2398bc6c6e4 100644
--- a/drivers/clk/visconti/pll.c
+++ b/drivers/clk/visconti/pll.c
@@ -289,7 +289,7 @@ static void visconti_pll_add_lookup(struct visconti_pll_provider *ctx,
struct clk_hw *hw_clk,
unsigned int id)
{
- if (ctx->clk_data.hws && id)
+ if (id)
ctx->clk_data.hws[id] = hw_clk;
}


base-commit: 70faf946ad975c64efb2eb809f9139f304a494b0
--
2.34.1

2022-01-08 00:08:15

by Stephen Boyd

Subject: Re: [PATCH] clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup()

Quoting Nathan Chancellor (2022-01-07 10:33:03)
> Clang warns:
>
> drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (ctx->clk_data.hws && id)
> ~~~~~~~~~~~~~~^~~ ~~
> 1 warning generated.
>
> This array cannot be NULL if ctx is not NULL, which is allocated in
> visconti_init_pll(), so just remove the check, which matches other clk
> drivers.
>
> Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1564
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---

Applied to clk-next

2022-01-11 00:39:19

by Nobuhiro Iwamatsu

Subject: RE: [PATCH] clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup()

Hi Nathan,

Thanks for your patch.

> -----Original Message-----
> From: Nathan Chancellor <[email protected]>
> Sent: Saturday, January 8, 2022 3:33 AM
> To: Michael Turquette <[email protected]>; Stephen Boyd
> <[email protected]>; iwamatsu nobuhiro($B4d>>(B $B?.MN(B $B""#S#W#C"~#A#C#T(B)
> <[email protected]>
> Cc: Nick Desaulniers <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; Nathan Chancellor <[email protected]>; kernel test
> robot <[email protected]>
> Subject: [PATCH] clk: visconti: Remove pointless NULL check in
> visconti_pll_add_lookup()
>
> Clang warns:
>
> drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws'
> will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (ctx->clk_data.hws && id)
> ~~~~~~~~~~~~~~^~~ ~~
> 1 warning generated.
>
> This array cannot be NULL if ctx is not NULL, which is allocated in
> visconti_init_pll(), so just remove the check, which matches other clk drivers.
>
> Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and
> reset driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1564
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
> drivers/clk/visconti/pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Nobuhiro Iwamatsu <[email protected]>

Best regards,
Nobuhiro