2021-10-26 09:45:07

by YE Chengfeng

[permalink] [raw]
Subject: drivers/clk/sunxi-ng: suspected missing null check for callsite of clk_hw_get_parent

Hi,

https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/drivers/clk/sunxi-ng/ccu_gate.c#L101
https://github.com/torvalds/linux/blob/master/drivers/clk/sunxi-ng/ccu_mux.c#L93

Our experimental static analysis tool detects a null-ptr-reference problem. It could be false positive, we report this to you just in case.

In these two call sites of clk_hw_get_parent, the return pointer is not null-check. We are not familiar with the code, and don't know whether it would be a potential null pointer dereference problem. Would you like to spare some time to have a look at it?

Thanks so much,
Chengfeng