2021-11-05 13:50:33

by YE Chengfeng

Subject: [PATCH] HSI: core: Fix return freed object in hsi_new_client

cl is freed on error of calling device_register, but this
object is return later, which will cause uaf issue. Fix it
by return NULL on error.

Signed-off-by: Chengfeng Ye <[email protected]>
---
drivers/hsi/hsi_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c
index ec90713564e3..884066109699 100644
--- a/drivers/hsi/hsi_core.c
+++ b/drivers/hsi/hsi_core.c
@@ -102,6 +102,7 @@ struct hsi_client *hsi_new_client(struct hsi_port *port,
if (device_register(&cl->device) < 0) {
pr_err("hsi: failed to register client: %s\n", info->name);
put_device(&cl->device);
+ goto err;
}

return cl;
--
2.17.1

2021-11-05 16:32:15

by YE Chengfeng

Subject: 回复: [PATCH] HSI: core: Fix return freed obj ect in hsi_new_client

Hi,

We send a patch for this suspected uaf issue. Would you like to have a look at it?

Best regards,
Chengfeng

-----?ʼ?ԭ??-----
??????: YE Chengfeng
????ʱ??: 2021??11??5?? 21:45
?ռ???: [email protected]
????: [email protected]; YE Chengfeng <[email protected]>
????: [PATCH] HSI: core: Fix return freed object in hsi_new_client

cl is freed on error of calling device_register, but this object is return later, which will cause uaf issue. Fix it by return NULL on error.

Signed-off-by: Chengfeng Ye <[email protected]>
---
drivers/hsi/hsi_core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index ec90713564e3..884066109699 100644
--- a/drivers/hsi/hsi_core.c
+++ b/drivers/hsi/hsi_core.c
@@ -102,6 +102,7 @@ struct hsi_client *hsi_new_client(struct hsi_port *port,
if (device_register(&cl->device) < 0) {
pr_err("hsi: failed to register client: %s\n", info->name);
put_device(&cl->device);
+ goto err;
}

return cl;
--
2.17.1