This fixes the sound not working from internal speakers on
Lenovo Legion Y9000X 2022 IAH7 models.
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors when configuring IRQs (by Stefan Binding)
See also <https://lore.kernel.org/lkml/[email protected]/>
Change from v3 <https://lore.kernel.org/lkml/TYCP286MB25357A4599E935F26A8AAB24C40E2@TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM/T/>:
- Remove the patch for cs35l41 to obey the trigger type from DSDT, for it is rarely used, and
the existing samples (Y9000X 2022 IAH7) has wrong trigger type in DSDT, which makes this change
useless.
- Instead, ignore errors when configuring interrupts to allow laptops with bad ACPI to play audio.
(via a patch from Stefan Binding)
Change from v2 <https://lore.kernel.org/lkml/TYCP286MB253523D85F6E0ECAA3E03D58C40E2@TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM/T/>:
- Correct spkid gpio index.
Change from v1 <https://lore.kernel.org/lkml/TYCP286MB25352F3E995FED9CCE90F1F6C40B2@TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM/T/>:
- Add a patch for cs35l41 to obey the trigger type from DSDT.
- Avoid disabling interupts for second amps.
ArcticLampyrid (1):
ALSA: hda/realtek: Fix internal speakers for Legion Y9000X 2022 IAH7
sound/pci/hda/cs35l41_hda_property.c | 2 ++
sound/pci/hda/patch_realtek.c | 1 +
2 files changed, 3 insertions(+)
--
2.45.0
This fixes the sound not working from internal speakers on
Lenovo Legion Y9000X 2022 IAH7 models.
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
Signed-off-by: Junhao Pei <[email protected]>
---
sound/pci/hda/cs35l41_hda_property.c | 2 ++
sound/pci/hda/patch_realtek.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 8fb688e41414..ee195737d388 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -109,6 +109,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
{ "10431F1F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 0, 0, 0 },
{ "10431F62", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
{ "10433A60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
+ { "17AA386E", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 2, -1, 0, 0, 0 },
{ "17AA386F", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, -1, -1, 0, 0, 0 },
{ "17AA3877", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
{ "17AA3878", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
@@ -500,6 +501,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
{ "CSC3551", "10431F1F", generic_dsd_config },
{ "CSC3551", "10431F62", generic_dsd_config },
{ "CSC3551", "10433A60", generic_dsd_config },
+ { "CSC3551", "17AA386E", generic_dsd_config },
{ "CSC3551", "17AA386F", generic_dsd_config },
{ "CSC3551", "17AA3877", generic_dsd_config },
{ "CSC3551", "17AA3878", generic_dsd_config },
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b29739bd330b..5c13af8a11a4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10496,6 +10496,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x3853, "Lenovo Yoga 7 15ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
SND_PCI_QUIRK(0x17aa, 0x3855, "Legion 7 16ITHG6", ALC287_FIXUP_LEGION_16ITHG6),
SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
+ SND_PCI_QUIRK(0x17aa, 0x386e, "Legion Y9000X 2022 IAH7", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x386f, "Legion Pro 7/7i", ALC287_FIXUP_LENOVO_LEGION_7),
SND_PCI_QUIRK(0x17aa, 0x3870, "Lenovo Yoga 7 14ARB7", ALC287_FIXUP_YOGA7_14ARB7_I2C),
SND_PCI_QUIRK(0x17aa, 0x3877, "Lenovo Legion 7 Slim 16ARHA7", ALC287_FIXUP_CS35L41_I2C_2),
--
2.45.0
On 06. 05. 24 9:27, ArcticLampyrid wrote:
> This fixes the sound not working from internal speakers on
> Lenovo Legion Y9000X 2022 IAH7 models.
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
>
> This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors when configuring IRQs (by Stefan Binding)
> See also <https://lore.kernel.org/lkml/[email protected]/>
We don't accept commits from anonymous sources. Please, follow
Documentation/process/submitting-patches.rst .
Jaroslav
--
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
> On 06. 05. 24 9:27, ArcticLampyrid wrote:
> > This fixes the sound not working from internal speakers on
> > Lenovo Legion Y9000X 2022 IAH7 models.
> >
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
> >
> > This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors
> > when configuring IRQs (by Stefan Binding) See also
> > <https://lore.kernel.org/lkml/[email protected]
> > irrus.com/>
> We don't accept commits from anonymous sources. Please, follow
> Documentation/process/submitting-patches.rst .
>
> Jaroslav
I've signed it off in commit message.
> Signed-off-by: Junhao Pei <[email protected]>
On Mon, 06 May 2024 09:32:56 +0200,
ArcticLampyrid wrote:
>
> > On 06. 05. 24 9:27, ArcticLampyrid wrote:
> > > This fixes the sound not working from internal speakers on
> > > Lenovo Legion Y9000X 2022 IAH7 models.
> > >
> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218744
> > >
> > > This patch depends on [PATCH v1 1/2] ALSA: hda: cs35l41: Ignore errors
> > > when configuring IRQs (by Stefan Binding) See also
> > > <https://lore.kernel.org/lkml/[email protected]
> > > irrus.com/>
> > We don't accept commits from anonymous sources. Please, follow
> > Documentation/process/submitting-patches.rst .
> >
> > Jaroslav
>
> I've signed it off in commit message.
> > Signed-off-by: Junhao Pei <[email protected]>
The From line doesn't match with your Signed-off-by line.
Please align it and resubmit.
thanks,
Takashi
> The From line doesn't match with your Signed-off-by line.
> Please align it and resubmit.
Well, okey, it's okey...
Resend here: <https://lore.kernel.org/lkml/TYCP286MB2535E8C7B2F9E7EDD75C4382C41C2@TYCP286MB2535.JPNP286.PROD.OUTLOOK.COM/T/>