2024-02-08 14:57:07

by Biju Das

Subject: RE: [PATCH 02/17] dt-bindings: clock: r9a07g044-cpg: Add power domain IDs

Hi Claudiu,

> -----Original Message-----
> From: Claudiu <[email protected]>
> Sent: Thursday, February 8, 2024 12:43 PM
> Subject: [PATCH 02/17] dt-bindings: clock: r9a07g044-cpg: Add power domain
> IDs
>
> From: Claudiu Beznea <[email protected]>
>
> Add power domain IDs for RZ/G2L (R9A07G044) SoC.
>
> Signed-off-by: Claudiu Beznea <[email protected]>
> ---
> include/dt-bindings/clock/r9a07g044-cpg.h | 58 +++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/include/dt-bindings/clock/r9a07g044-cpg.h b/include/dt-
> bindings/clock/r9a07g044-cpg.h
> index 0bb17ff1a01a..e209f96f92b7 100644
> --- a/include/dt-bindings/clock/r9a07g044-cpg.h
> +++ b/include/dt-bindings/clock/r9a07g044-cpg.h
> @@ -217,4 +217,62 @@
> #define R9A07G044_ADC_ADRST_N 82
> #define R9A07G044_TSU_PRESETN 83
>
> +/* Power domain IDs. */
> +#define R9A07G044_PD_ALWAYS_ON 0
> +#define R9A07G044_PD_GIC 1
> +#define R9A07G044_PD_IA55 2
> +#define R9A07G044_PD_MHU 3
> +#define R9A07G044_PD_CORESIGHT 4
> +#define R9A07G044_PD_SYC 5
> +#define R9A07G044_PD_DMAC 6
> +#define R9A07G044_PD_GTM0 7
> +#define R9A07G044_PD_GTM1 8
> +#define R9A07G044_PD_GTM2 9
> +#define R9A07G044_PD_MTU 10
> +#define R9A07G044_PD_POE3 11
> +#define R9A07G044_PD_GPT 12
> +#define R9A07G044_PD_POEGA 13
> +#define R9A07G044_PD_POEGB 14
> +#define R9A07G044_PD_POEGC 15
> +#define R9A07G044_PD_POEGD 16
> +#define R9A07G044_PD_WDT0 17
> +#define R9A07G044_PD_WDT1 18
> +#define R9A07G044_PD_SPI 19
> +#define R9A07G044_PD_SDHI0 20
> +#define R9A07G044_PD_SDHI1 21
> +#define R9A07G044_PD_3DGE 22
> +#define R9A07G044_PD_ISU 23
> +#define R9A07G044_PD_VCPL4 24
> +#define R9A07G044_PD_CRU 25
> +#define R9A07G044_PD_MIPI_DSI 26
> +#define R9A07G044_PD_LCDC 27
> +#define R9A07G044_PD_SSI0 28
> +#define R9A07G044_PD_SSI1 29
> +#define R9A07G044_PD_SSI2 30
> +#define R9A07G044_PD_SSI3 31
> +#define R9A07G044_PD_SRC 32
> +#define R9A07G044_PD_USB0 33
> +#define R9A07G044_PD_USB1 34
> +#define R9A07G044_PD_USB_PHY 35
> +#define R9A07G044_PD_ETHER0 36
> +#define R9A07G044_PD_ETHER1 37
> +#define R9A07G044_PD_I2C0 38
> +#define R9A07G044_PD_I2C1 39
> +#define R9A07G044_PD_I2C2 40
> +#define R9A07G044_PD_I2C3 41
> +#define R9A07G044_PD_SCIF0 42
> +#define R9A07G044_PD_SCIF1 43
> +#define R9A07G044_PD_SCIF2 44
> +#define R9A07G044_PD_SCIF3 45
> +#define R9A07G044_PD_SCIF4 46
> +#define R9A07G044_PD_SCI0 47
> +#define R9A07G044_PD_SCI1 48
> +#define R9A07G044_PD_IRDA 49
> +#define R9A07G044_PD_RSPI0 50
> +#define R9A07G044_PD_RSPI1 51
> +#define R9A07G044_PD_RSPI2 52
> +#define R9A07G044_PD_CANFD 53
> +#define R9A07G044_PD_ADC 54
> +#define R9A07G044_PD_TSU 55

Not sure these PD id's can be generic and used across all RZ/G2L family
devices and RZ/V2M?

Cheers,
Biju

> +
> #endif /* __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ */
> --
> 2.39.2
>

2024-02-09 12:20:19

by Claudiu

Subject: Re: [PATCH 02/17] dt-bindings: clock: r9a07g044-cpg: Add power domain IDs

Hi, Biju,

On 08.02.2024 16:39, Biju Das wrote:
> Hi Claudiu,
>
>> -----Original Message-----
>> From: Claudiu <[email protected]>
>> Sent: Thursday, February 8, 2024 12:43 PM
>> Subject: [PATCH 02/17] dt-bindings: clock: r9a07g044-cpg: Add power domain
>> IDs
>>
>> From: Claudiu Beznea <[email protected]>
>>
>> Add power domain IDs for RZ/G2L (R9A07G044) SoC.
>>
>> Signed-off-by: Claudiu Beznea <[email protected]>
>> ---
>> include/dt-bindings/clock/r9a07g044-cpg.h | 58 +++++++++++++++++++++++
>> 1 file changed, 58 insertions(+)
>>
>> diff --git a/include/dt-bindings/clock/r9a07g044-cpg.h b/include/dt-
>> bindings/clock/r9a07g044-cpg.h
>> index 0bb17ff1a01a..e209f96f92b7 100644
>> --- a/include/dt-bindings/clock/r9a07g044-cpg.h
>> +++ b/include/dt-bindings/clock/r9a07g044-cpg.h
>> @@ -217,4 +217,62 @@
>> #define R9A07G044_ADC_ADRST_N 82
>> #define R9A07G044_TSU_PRESETN 83
>>
>> +/* Power domain IDs. */
>> +#define R9A07G044_PD_ALWAYS_ON 0
>> +#define R9A07G044_PD_GIC 1
>> +#define R9A07G044_PD_IA55 2
>> +#define R9A07G044_PD_MHU 3
>> +#define R9A07G044_PD_CORESIGHT 4
>> +#define R9A07G044_PD_SYC 5
>> +#define R9A07G044_PD_DMAC 6
>> +#define R9A07G044_PD_GTM0 7
>> +#define R9A07G044_PD_GTM1 8
>> +#define R9A07G044_PD_GTM2 9
>> +#define R9A07G044_PD_MTU 10
>> +#define R9A07G044_PD_POE3 11
>> +#define R9A07G044_PD_GPT 12
>> +#define R9A07G044_PD_POEGA 13
>> +#define R9A07G044_PD_POEGB 14
>> +#define R9A07G044_PD_POEGC 15
>> +#define R9A07G044_PD_POEGD 16
>> +#define R9A07G044_PD_WDT0 17
>> +#define R9A07G044_PD_WDT1 18
>> +#define R9A07G044_PD_SPI 19
>> +#define R9A07G044_PD_SDHI0 20
>> +#define R9A07G044_PD_SDHI1 21
>> +#define R9A07G044_PD_3DGE 22
>> +#define R9A07G044_PD_ISU 23
>> +#define R9A07G044_PD_VCPL4 24
>> +#define R9A07G044_PD_CRU 25
>> +#define R9A07G044_PD_MIPI_DSI 26
>> +#define R9A07G044_PD_LCDC 27
>> +#define R9A07G044_PD_SSI0 28
>> +#define R9A07G044_PD_SSI1 29
>> +#define R9A07G044_PD_SSI2 30
>> +#define R9A07G044_PD_SSI3 31
>> +#define R9A07G044_PD_SRC 32
>> +#define R9A07G044_PD_USB0 33
>> +#define R9A07G044_PD_USB1 34
>> +#define R9A07G044_PD_USB_PHY 35
>> +#define R9A07G044_PD_ETHER0 36
>> +#define R9A07G044_PD_ETHER1 37
>> +#define R9A07G044_PD_I2C0 38
>> +#define R9A07G044_PD_I2C1 39
>> +#define R9A07G044_PD_I2C2 40
>> +#define R9A07G044_PD_I2C3 41
>> +#define R9A07G044_PD_SCIF0 42
>> +#define R9A07G044_PD_SCIF1 43
>> +#define R9A07G044_PD_SCIF2 44
>> +#define R9A07G044_PD_SCIF3 45
>> +#define R9A07G044_PD_SCIF4 46
>> +#define R9A07G044_PD_SCI0 47
>> +#define R9A07G044_PD_SCI1 48
>> +#define R9A07G044_PD_IRDA 49
>> +#define R9A07G044_PD_RSPI0 50
>> +#define R9A07G044_PD_RSPI1 51
>> +#define R9A07G044_PD_RSPI2 52
>> +#define R9A07G044_PD_CANFD 53
>> +#define R9A07G044_PD_ADC 54
>> +#define R9A07G044_PD_TSU 55
>
> Not sure these PD id's can be generic and used across all RZ/G2L family
> devices and RZ/V2M?

That may be another approach. I chose this one to have everything SoC
specific in a single place. With this, e.g., we can have all the SCIF
related IDs grouped together (as we know from the beginning how many SCIF
blocks a SoC has):

+#define R9A07G044_PD_SCIF0 42
+#define R9A07G044_PD_SCIF1 43
+#define R9A07G044_PD_SCIF2 44
+#define R9A07G044_PD_SCIF3 45
+#define R9A07G044_PD_SCIF4 46

If a single file with all the IDs for all the SoC will be used then, as
every SoC will have a different number of SCIFs, I2Cs, RSPIs, to keep the
DT binding backward compatibility, we will end up with these IDs not being
grouped on functionality, e.g., we may end up with something like:

+#define R9A07G044_PD_I2C0 38
+#define R9A07G044_PD_I2C1 39
+#define R9A07G044_PD_I2C2 40
+#define R9A07G044_PD_I2C3 41
+#define R9A07G044_PD_SCIF0 42
+#define R9A07G044_PD_SCIF1 43
+#define R9A07G044_PD_SCIF2 44
+#define R9A07G044_PD_SCIF3 45
+#define R9A07G044_PD_SCIF4 46
+#define R9A07G044_PD_SCI0 47
+#define R9A07G044_PD_SCI1 48
+#define R9A07G044_PD_IRDA 49
+#define R9A07G044_PD_RSPI0 50
+#define R9A07G044_PD_RSPI1 51
+#define R9A07G044_PD_RSPI2 52
+#define R9A07G044_PD_CANFD 53
+#define R9A07G044_PD_ADC 54
+#define R9A07G044_PD_TSU 55

+#define R9A07G044_PD_SCIF5 56
+#define R9A07G044_PD_SCIF6 57
+#define R9A07G044_PD_I2C4 58
+#define R9A07G044_PD_RSPI3 58
+#define R9A07G044_PD_RSPI4 59

Of course, I can adjust it if Geert wants it differently.

Thank you,
Claudiu Beznea

>
> Cheers,
> Biju
>
>> +
>> #endif /* __DT_BINDINGS_CLOCK_R9A07G044_CPG_H__ */
>> --
>> 2.39.2
>>
>