2021-10-26 09:58:36

by [email protected]

[permalink] [raw]
Subject: [PATCH] ACPI: Add AEST in ACPI Table Definitions

When We added AEST using the Upgrading ACPI tables via initrd function,
the kernel could not recognize the AEST, so We added AEST the ACPI table
definition.

Signed-off-by: Shuuichirou Ishii <[email protected]>
---
drivers/acpi/tables.c | 2 +-
include/acpi/actbl2.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index f9383736fa0f..ab0fb4c33e07 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -499,7 +499,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
- ACPI_SIG_NHLT };
+ ACPI_SIG_NHLT, ACPI_SIG_AEST };

#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
index a47b32a5cbde..b586e40d4b86 100644
--- a/include/acpi/actbl2.h
+++ b/include/acpi/actbl2.h
@@ -48,6 +48,7 @@
#define ACPI_SIG_SDEV "SDEV" /* Secure Devices table */
#define ACPI_SIG_NHLT "NHLT" /* Non-HDAudio Link Table */
#define ACPI_SIG_SVKL "SVKL" /* Storage Volume Key Location Table */
+#define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */

/*
* All tables must be byte-packed to match the ACPI specification, since
--
2.27.0


2021-11-04 07:16:51

by [email protected]

[permalink] [raw]
Subject: RE: [PATCH] ACPI: Add AEST in ACPI Table Definitions

ping?

P.S.
We should have added the maintainer of ACPI FOR ARM64 (ACPI/arm64) first,
but since AEST is an arm-spec ACPI table, added the concerned persons
as new e-mail addresses.

> -----Original Message-----
> From: Shuuichirou Ishii <[email protected]>
> Sent: Tuesday, October 26, 2021 4:53 PM
> To: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Cc: Ishii, Shuuichirou/$B@P0f(B $B<~0lO:(B <[email protected]>
> Subject: [PATCH] ACPI: Add AEST in ACPI Table Definitions
>
> When We added AEST using the Upgrading ACPI tables via initrd function, the
> kernel could not recognize the AEST, so We added AEST the ACPI table definition.
>
> Signed-off-by: Shuuichirou Ishii <[email protected]>
> ---
> drivers/acpi/tables.c | 2 +-
> include/acpi/actbl2.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> f9383736fa0f..ab0fb4c33e07 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -499,7 +499,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE]
> __initconst = {
> ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> - ACPI_SIG_NHLT };
> + ACPI_SIG_NHLT, ACPI_SIG_AEST };
>
> #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>
> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> a47b32a5cbde..b586e40d4b86 100644
> --- a/include/acpi/actbl2.h
> +++ b/include/acpi/actbl2.h
> @@ -48,6 +48,7 @@
> #define ACPI_SIG_SDEV "SDEV" /* Secure Devices table */
> #define ACPI_SIG_NHLT "NHLT" /* Non-HDAudio Link Table
> */
> #define ACPI_SIG_SVKL "SVKL" /* Storage Volume Key
> Location Table */
> +#define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */
>
> /*
> * All tables must be byte-packed to match the ACPI specification, since
> --
> 2.27.0

2021-11-04 11:32:47

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: Add AEST in ACPI Table Definitions

On Thu, Nov 4, 2021 at 8:14 AM [email protected]
<[email protected]> wrote:
>
> ping?
>
> P.S.
> We should have added the maintainer of ACPI FOR ARM64 (ACPI/arm64) first,
> but since AEST is an arm-spec ACPI table, added the concerned persons
> as new e-mail addresses.

Please resend the patch, then, with all of the requisite addresses
present in the CC list.

> > -----Original Message-----
> > From: Shuuichirou Ishii <[email protected]>
> > Sent: Tuesday, October 26, 2021 4:53 PM
> > To: [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]
> > Cc: Ishii, Shuuichirou/石井 周一郎 <[email protected]>
> > Subject: [PATCH] ACPI: Add AEST in ACPI Table Definitions
> >
> > When We added AEST using the Upgrading ACPI tables via initrd function, the
> > kernel could not recognize the AEST, so We added AEST the ACPI table definition.
> >
> > Signed-off-by: Shuuichirou Ishii <[email protected]>
> > ---
> > drivers/acpi/tables.c | 2 +-
> > include/acpi/actbl2.h | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > f9383736fa0f..ab0fb4c33e07 100644
> > --- a/drivers/acpi/tables.c
> > +++ b/drivers/acpi/tables.c
> > @@ -499,7 +499,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE]
> > __initconst = {
> > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
> > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > - ACPI_SIG_NHLT };
> > + ACPI_SIG_NHLT, ACPI_SIG_AEST };
> >
> > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> >
> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> > a47b32a5cbde..b586e40d4b86 100644
> > --- a/include/acpi/actbl2.h
> > +++ b/include/acpi/actbl2.h
> > @@ -48,6 +48,7 @@
> > #define ACPI_SIG_SDEV "SDEV" /* Secure Devices table */
> > #define ACPI_SIG_NHLT "NHLT" /* Non-HDAudio Link Table
> > */
> > #define ACPI_SIG_SVKL "SVKL" /* Storage Volume Key
> > Location Table */
> > +#define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */
> >
> > /*
> > * All tables must be byte-packed to match the ACPI specification, since
> > --
> > 2.27.0
>

2021-11-04 23:35:18

by [email protected]

[permalink] [raw]
Subject: RE: [PATCH] ACPI: Add AEST in ACPI Table Definitions

Hi, Rafael.

Thank you for your comments.
We will respond as you suggested.

Best regards,
Shuuichirou.

> -----Original Message-----
> From: Rafael J. Wysocki <[email protected]>
> Sent: Thursday, November 4, 2021 8:31 PM
> To: Ishii, Shuuichirou/石井 周一郎 <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH] ACPI: Add AEST in ACPI Table Definitions
>
> On Thu, Nov 4, 2021 at 8:14 AM [email protected]
> <[email protected]> wrote:
> >
> > ping?
> >
> > P.S.
> > We should have added the maintainer of ACPI FOR ARM64 (ACPI/arm64)
> > first, but since AEST is an arm-spec ACPI table, added the concerned
> > persons as new e-mail addresses.
>
> Please resend the patch, then, with all of the requisite addresses present in the
> CC list.
>
> > > -----Original Message-----
> > > From: Shuuichirou Ishii <[email protected]>
> > > Sent: Tuesday, October 26, 2021 4:53 PM
> > > To: [email protected]; [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected]; [email protected]
> > > Cc: Ishii, Shuuichirou/石井 周一郎 <[email protected]>
> > > Subject: [PATCH] ACPI: Add AEST in ACPI Table Definitions
> > >
> > > When We added AEST using the Upgrading ACPI tables via initrd
> > > function, the kernel could not recognize the AEST, so We added AEST the
> ACPI table definition.
> > >
> > > Signed-off-by: Shuuichirou Ishii <[email protected]>
> > > ---
> > > drivers/acpi/tables.c | 2 +-
> > > include/acpi/actbl2.h | 1 +
> > > 2 files changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index
> > > f9383736fa0f..ab0fb4c33e07 100644
> > > --- a/drivers/acpi/tables.c
> > > +++ b/drivers/acpi/tables.c
> > > @@ -499,7 +499,7 @@ static const char
> > > table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
> > > ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT,
> ACPI_SIG_FADT,
> > > ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
> > > ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
> > > - ACPI_SIG_NHLT };
> > > + ACPI_SIG_NHLT, ACPI_SIG_AEST };
> > >
> > > #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
> > >
> > > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h index
> > > a47b32a5cbde..b586e40d4b86 100644
> > > --- a/include/acpi/actbl2.h
> > > +++ b/include/acpi/actbl2.h
> > > @@ -48,6 +48,7 @@
> > > #define ACPI_SIG_SDEV "SDEV" /* Secure Devices table
> */
> > > #define ACPI_SIG_NHLT "NHLT" /* Non-HDAudio Link
> Table
> > > */
> > > #define ACPI_SIG_SVKL "SVKL" /* Storage Volume Key
> > > Location Table */
> > > +#define ACPI_SIG_AEST "AEST" /* Arm Error Source Table */
> > >
> > > /*
> > > * All tables must be byte-packed to match the ACPI specification,
> > > since
> > > --
> > > 2.27.0
> >