In accordance with the way the device DT-node is actually defined in
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed
by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the
DT-bindings lack. Let's extend the interrupts property constraints then
and fix the schema example so one would be acceptable by the actual device
DT-bindings.
Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller")
Signed-off-by: Serge Semin <[email protected]>
---
Changelog v5:
- This is a new patch added on the v5 release of the patchset.
---
.../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
index 30b6396d83c8..aea0e2bcdd77 100644
--- a/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
@@ -36,7 +36,7 @@ properties:
- const: mpu
interrupts:
- maxItems: 1
+ maxItems: 2
clocks:
items:
@@ -94,8 +94,9 @@ examples:
#interrupt-cells = <1>;
ranges = <0x81000000 0 0x40000000 0 0x40000000 0 0x00010000>,
<0x82000000 0 0x50000000 0 0x50000000 0 0x20000000>;
- interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "intr";
+ interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "msi", "intr";
interrupt-map-mask = <0 0 0 7>;
interrupt-map =
<0 0 0 1 &gic GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH
--
2.35.1
On Mon, Aug 22, 2022 at 09:46:43PM +0300, Serge Semin wrote:
> In accordance with the way the device DT-node is actually defined in
> arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed
> by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the
> DT-bindings lack. Let's extend the interrupts property constraints then
> and fix the schema example so one would be acceptable by the actual device
> DT-bindings.
>
> Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti PCIe controller")
> Signed-off-by: Serge Semin <[email protected]>
>
> ---
>
> Changelog v5:
> - This is a new patch added on the v5 release of the patchset.
> ---
> .../devicetree/bindings/pci/toshiba,visconti-pcie.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
No need for this to be in this series.
Acked-by: Rob Herring <[email protected]>
> -----Original Message-----
> From: Serge Semin <[email protected]>
> Sent: Tuesday, August 23, 2022 3:47 AM
> To: Rob Herring <[email protected]>; Rob Herring <[email protected]>;
> Krzysztof Kozlowski <[email protected]>; Bjorn Helgaas
> <[email protected]>; Lorenzo Pieralisi <[email protected]>;
> Jingoo Han <[email protected]>; Gustavo Pimentel
> <[email protected]>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ
> ◯ＡＣＴ) <[email protected]>
> Cc: Serge Semin <[email protected]>; Serge Semin
> <[email protected]>; Alexey Malahov
> <[email protected]>; Pavel Parkhomenko
> <[email protected]>; Krzysztof Wilczyński
> <[email protected]>; Frank Li <[email protected]>; Manivannan Sadhasivam
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: [PATCH v5 02/20] dt-bindings: visconti-pcie: Fix interrupts array max
> constraints
>
> In accordance with the way the device DT-node is actually defined in
> arch/arm64/boot/dts/toshiba/tmpv7708.dtsi and the way the device is probed
> by the DW PCIe driver there are two IRQs it actually has. It's MSI IRQ the
> DT-bindings lack. Let's extend the interrupts property constraints then and fix
> the schema example so one would be acceptable by the actual device
> DT-bindings.
>
> Fixes: 17c1b16340f0 ("dt-bindings: pci: Add DT binding for Toshiba Visconti
> PCIe controller")
> Signed-off-by: Serge Semin <[email protected]>
Thanks for this patch.
Acked-by: Nobuhiro Iwamatsu <[email protected]>
Best regards,
Nobuhiro