On 5/20/22 02:00, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> .../bindings/watchdog/toshiba,visconti-wdt.yaml | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..52c0e0c022ea 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,15 @@ additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
>
> - wdt_clk: wdt-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <150000000>;
> - #clock-cells = <0>;
> - };
> -
> - watchdog@28330000 {
> + wdt: watchdog@28330000 {
> compatible = "toshiba,visconti-wdt";
> reg = <0 0x28330000 0 0x1000>;
> - clocks = <&wdt_clk>;
> - timeout-sec = <20>;
> + clocks = <&pismu TMPV770X_CLK_WDTCLK>;
> };
> };
wdt: isn't needed in the example, and I question if it
really improves the quality of the example to remove
timeout-sec.
Guenter
Hi Guenter,
Thanks for your review.
> -----Original Message-----
> From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
> Sent: Friday, May 20, 2022 6:11 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <[email protected]>; Wim Van Sebroeck
> <[email protected]>
> Cc: [email protected]; ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩ
> ＴＣ○ＥＡ開) <[email protected]>;
> [email protected]; [email protected];
> [email protected]; Rob Herring <[email protected]>; Krzysztof
> Kozlowski <[email protected]>; Rob Herring <[email protected]>
> Subject: Re: [PATCH v2] dt-bindings: watchdog: toshiba,visconti-wdt: Update
> the common clock properties
>
> On 5/20/22 02:00, Nobuhiro Iwamatsu wrote:
> > The clock for this driver switched to the common clock controller driver.
> > Therefore, update common clock properties for watchdog in the binding
> document.
> > And this matched this example with the actual dts.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> > Acked-by: Rob Herring <[email protected]>
> > ---
> > .../bindings/watchdog/toshiba,visconti-wdt.yaml | 13
> ++++---------
> > 1 file changed, 4 insertions(+), 9 deletions(-)
> >
> > diff --git
> >
> a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> >
> b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> > index 690e19ce4b87..52c0e0c022ea 100644
> > ---
> >
> a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> > +++
> b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.
> > +++ yaml
> > @@ -35,20 +35,15 @@ additionalProperties: false
> >
> > examples:
> > - |
> > + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> > +
> > soc {
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > - wdt_clk: wdt-clk {
> > - compatible = "fixed-clock";
> > - clock-frequency = <150000000>;
> > - #clock-cells = <0>;
> > - };
> > -
> > - watchdog@28330000 {
> > + wdt: watchdog@28330000 {
> > compatible = "toshiba,visconti-wdt";
> > reg = <0 0x28330000 0 0x1000>;
> > - clocks = <&wdt_clk>;
> > - timeout-sec = <20>;
> > + clocks = <&pismu TMPV770X_CLK_WDTCLK>;
> > };
> > };
>
> wdt: isn't needed in the example, and I question if it really improves the quality
> of the example to remove timeout-sec.
OK, I make a fix that doesn't remove timeout-sec.
Best regards,
Nobuhiro