2022-07-20 12:52:50

by Peng Liu

Subject: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing

From: Peng Liu <[email protected]>

HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.

Signed-off-by: Peng Liu <[email protected]>
---
scripts/gdb/linux/timerlist.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
index 8281da068c5b..249f0e804b24 100644
--- a/scripts/gdb/linux/timerlist.py
+++ b/scripts/gdb/linux/timerlist.py
@@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
max_clock_bases = gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")

text = "Timer List Version: gdb scripts\n"
- text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(max_clock_bases)
+ text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
+ max_clock_bases.type.fields()[max_clock_bases].enumval)
text += "now at {} nsecs\n".format(ktime_get())

for cpu in cpus.each_online_cpu():
--
2.25.1

2022-08-04 09:20:07

by Peng Liu

Subject: Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing

On 2022/7/20 20:27, [email protected] wrote:
> From: Peng Liu <[email protected]>
>
> HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
> it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.
>
> Signed-off-by: Peng Liu <[email protected]>
> ---
> scripts/gdb/linux/timerlist.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 8281da068c5b..249f0e804b24 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
> max_clock_bases = gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")
>
> text = "Timer List Version: gdb scripts\n"
> - text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(max_clock_bases)
> + text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
> + max_clock_bases.type.fields()[max_clock_bases].enumval)
> text += "now at {} nsecs\n".format(ktime_get())
>
> for cpu in cpus.each_online_cpu():

2022-08-22 09:54:57

by Peng Liu

Subject: Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing

ping

On 2022/8/4 16:50, Peng Liu wrote:
>
> On 2022/7/20 20:27, [email protected] wrote:
>> From: Peng Liu <[email protected]>
>>
>> HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
>> it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.
>>
>> Signed-off-by: Peng Liu <[email protected]>
>> ---
>>   scripts/gdb/linux/timerlist.py | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/timerlist.py
>> b/scripts/gdb/linux/timerlist.py
>> index 8281da068c5b..249f0e804b24 100644
>> --- a/scripts/gdb/linux/timerlist.py
>> +++ b/scripts/gdb/linux/timerlist.py
>> @@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
>>           max_clock_bases =
>> gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")
>>             text = "Timer List Version: gdb scripts\n"
>> -        text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(max_clock_bases)
>> +        text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
>> + max_clock_bases.type.fields()[max_clock_bases].enumval)
>>           text += "now at {} nsecs\n".format(ktime_get())
>>             for cpu in cpus.each_online_cpu():

2022-08-31 02:17:35

by Peng Liu

Subject: Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing

ping

On 2022/8/22 17:30, Peng Liu wrote:
> ping
>
> On 2022/8/4 16:50, Peng Liu wrote:
>>
>> On 2022/7/20 20:27, [email protected] wrote:
>>> From: Peng Liu <[email protected]>
>>>
>>> HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
>>> it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.
>>>
>>> Signed-off-by: Peng Liu <[email protected]>
>>> ---
>>>   scripts/gdb/linux/timerlist.py | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/gdb/linux/timerlist.py
>>> b/scripts/gdb/linux/timerlist.py
>>> index 8281da068c5b..249f0e804b24 100644
>>> --- a/scripts/gdb/linux/timerlist.py
>>> +++ b/scripts/gdb/linux/timerlist.py
>>> @@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
>>>           max_clock_bases =
>>> gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")
>>>             text = "Timer List Version: gdb scripts\n"
>>> -        text += "HRTIMER_MAX_CLOCK_BASES:
>>> {}\n".format(max_clock_bases)
>>> +        text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
>>> + max_clock_bases.type.fields()[max_clock_bases].enumval)
>>>           text += "now at {} nsecs\n".format(ktime_get())
>>>             for cpu in cpus.each_online_cpu():

2022-08-31 15:40:32

by Jan Kiszka

Subject: Re: [PATCH 3/3] scripts/gdb: fix lx-timerlist for HRTIMER_MAX_CLOCK_BASES printing

On 20.07.22 14:27, [email protected] wrote:
> From: Peng Liu <[email protected]>
>
> HRTIMER_MAX_CLOCK_BASES is of enum type hrtimer_base_type. To print
> it as an integer, HRTIMER_MAX_CLOCK_BASES should be converted first.
>
> Signed-off-by: Peng Liu <[email protected]>
> ---
> scripts/gdb/linux/timerlist.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 8281da068c5b..249f0e804b24 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -188,7 +188,8 @@ class LxTimerList(gdb.Command):
> max_clock_bases = gdb.parse_and_eval("HRTIMER_MAX_CLOCK_BASES")
>
> text = "Timer List Version: gdb scripts\n"
> - text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(max_clock_bases)
> + text += "HRTIMER_MAX_CLOCK_BASES: {}\n".format(
> + max_clock_bases.type.fields()[max_clock_bases].enumval)
> text += "now at {} nsecs\n".format(ktime_get())
>
> for cpu in cpus.each_online_cpu():

Reviewed-by: Jan Kiszka <[email protected]>

Jan

--
Siemens AG, Technology
Competence Center Embedded Linux