2002-03-04 00:35:54

by Andries E. Brouwer

Subject: [patch] Re: 2.4.19-pre2: ufs problems

Both Gerd Knorr and Jurgen Philippaerts complain about
problems mounting an ufs filesystem, one for BSD, the
other for Solaris.
The reason is the patch fragment in patch-2.4.19-pre2:

--- linux.orig/fs/ufs/super.c Thu Feb 28 18:24:57 2002
+++ linux/fs/ufs/super.c Wed Feb 27 20:34:30 2002
@@ -597,7 +597,11 @@
}

again:
- set_blocksize (sb->s_dev, block_size);
+ if (!set_blocksize (sb->s_dev, block_size)) {
+ printk(KERN_ERR "UFS: failed to set blocksize\n");
+ goto failed;
+ }
+
sb->s_blocksize = block_size;

/*

Indeed, set_blocksize returns 0 when all is well.
Thus, this change will always cause a failure.

Andries

[so, this patch fragment must be reverted, or the '!'
must be removed]

2002-03-05 19:16:47

by Marcelo Tosatti

Subject: Re: [patch] Re: 2.4.19-pre2: ufs problems

On Mon, 4 Mar 2002 [email protected] wrote:

> Both Gerd Knorr and Jurgen Philippaerts complain about
> problems mounting an ufs filesystem, one for BSD, the
> other for Solaris.
> The reason is the patch fragment in patch-2.4.19-pre2:
>
> --- linux.orig/fs/ufs/super.c Thu Feb 28 18:24:57 2002
> +++ linux/fs/ufs/super.c Wed Feb 27 20:34:30 2002
> @@ -597,7 +597,11 @@
> }
>
> again:
> - set_blocksize (sb->s_dev, block_size);
> + if (!set_blocksize (sb->s_dev, block_size)) {
> + printk(KERN_ERR "UFS: failed to set blocksize\n");
> + goto failed;
> + }
> +
> sb->s_blocksize = block_size;
>
> /*
>
> Indeed, set_blocksize returns 0 when all is well.
> Thus, this change will always cause a failure.

Fixed in my tree.

Thanks