From: David Woodhouse <[email protected]>
+int jffs2_prepare_follow_link(struct dentry *dentry, struct nameidata *nd,
+ const char **llink, struct page **ppage)
+ nd->flags |= LOOKUP_KFREE_NEEDED;
Urgh. Don't do that on my behalf - we'll just switch to using
page_follow_link, which to be honest I thought we'd already done --
there were definitely patches for it floating around.
Good. I think it would be worthwhile to find and submit such patches.
Not just for this attempt of mine, but it is generally a good idea
to keep things as uniform as possible.
I think these two ugly bits, and the entire nd argument of
prepare_follow_link can be eliminated, but apart from jffs2
that also requires a little work in proc.
Andries
[email protected] said:
> Good. I think it would be worthwhile to find and submit such patches.
> Not just for this attempt of mine, but it is generally a good idea to
> keep things as uniform as possible.
Er, and to prevent us from having to go to the flash, read and possibly
decompress the link target, every time someone opens a symlink such as
/lib/ld-linux.so.2 :)
--
dwmw2