2019-08-14 07:25:23

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1 1/4] arm64: dts: ls1028a-rdb: enable emmc hs400 mode

This patch is to enable emmc hs400 mode for ls1028ardb

Signed-off-by: Yinbo Zhu <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index 8a725409e881..f1e46cc4cea1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -92,8 +92,10 @@
};

&esdhc1 {
- status = "okay";
mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ bus-width = <8>;
+ status = "okay";
};

&i2c0 {
--
2.17.1


2019-08-14 07:25:30

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1 2/4] soc: fsl: guts: Add definition for LS1028A

Adding compatible string "ls1028a-dcfg" to initialize guts driver
for ls1028 and SoC die attribute definition for LS1028A

Signed-off-by: Yinbo Zhu <[email protected]>
---
drivers/soc/fsl/guts.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
index 1ef8068c8dd3..34810f9bb2ee 100644
--- a/drivers/soc/fsl/guts.c
+++ b/drivers/soc/fsl/guts.c
@@ -102,6 +102,11 @@ static const struct fsl_soc_die_attr fsl_soc_die[] = {
.svr = 0x87360000,
.mask = 0xff3f0000,
},
+ /* Die: LS1028A, SoC: LS1028A */
+ { .die = "LS1028A",
+ .svr = 0x870b0000,
+ .mask = 0xff3f0000,
+ },
{ },
};

@@ -224,6 +229,7 @@ static const struct of_device_id fsl_guts_of_match[] = {
{ .compatible = "fsl,ls1012a-dcfg", },
{ .compatible = "fsl,ls1046a-dcfg", },
{ .compatible = "fsl,lx2160a-dcfg", },
+ { .compatible = "fsl,ls1028a-dcfg", },
{}
};
MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
--
2.17.1

2019-08-14 07:25:43

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

dcfg use little endian that SoC register value will be correct

Signed-off-by: Yinbo Zhu <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index b0d4f8916ede..5538e8e354b2 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -162,7 +162,7 @@
dcfg: syscon@1e00000 {
compatible = "fsl,ls1028a-dcfg", "syscon";
reg = <0x0 0x1e00000 0x0 0x10000>;
- big-endian;
+ little-endian;
};

scfg: syscon@1fc0000 {
--
2.17.1

2019-08-14 07:26:11

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1 4/4] mmc: sdhci-of-esdhc: add erratum A011334 support in ls1028a 1.0 SoC

This patch is to add erratum A011334 support in ls1028a 1.0 SoC

Signed-off-by: Yinbo Zhu <[email protected]>
---
drivers/mmc/host/sdhci-of-esdhc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index b16f7d440f78..eb2b290447fc 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -1006,6 +1006,7 @@ static struct soc_device_attribute soc_incorrect_hostver[] = {
static struct soc_device_attribute soc_fixup_sdhc_clkdivs[] = {
{ .family = "QorIQ LX2160A", .revision = "1.0", },
{ .family = "QorIQ LX2160A", .revision = "2.0", },
+ { .family = "QorIQ LS1028A", .revision = "1.0", },
{ },
};

--
2.17.1

2019-08-15 11:52:04

by Adrian Hunter

[permalink] [raw]
Subject: Re: [PATCH v1 4/4] mmc: sdhci-of-esdhc: add erratum A011334 support in ls1028a 1.0 SoC

On 14/08/19 10:26 AM, Yinbo Zhu wrote:
> This patch is to add erratum A011334 support in ls1028a 1.0 SoC
>
> Signed-off-by: Yinbo Zhu <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index b16f7d440f78..eb2b290447fc 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -1006,6 +1006,7 @@ static struct soc_device_attribute soc_incorrect_hostver[] = {
> static struct soc_device_attribute soc_fixup_sdhc_clkdivs[] = {
> { .family = "QorIQ LX2160A", .revision = "1.0", },
> { .family = "QorIQ LX2160A", .revision = "2.0", },
> + { .family = "QorIQ LS1028A", .revision = "1.0", },
> { },
> };
>
>

2019-08-15 23:51:00

by Leo Li

[permalink] [raw]
Subject: Re: [PATCH v1 2/4] soc: fsl: guts: Add definition for LS1028A

On Wed, Aug 14, 2019 at 2:26 AM Yinbo Zhu <[email protected]> wrote:
>
> Adding compatible string "ls1028a-dcfg" to initialize guts driver
> for ls1028 and SoC die attribute definition for LS1028A
>
> Signed-off-by: Yinbo Zhu <[email protected]>

Applied for next.

> ---
> drivers/soc/fsl/guts.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
> index 1ef8068c8dd3..34810f9bb2ee 100644
> --- a/drivers/soc/fsl/guts.c
> +++ b/drivers/soc/fsl/guts.c
> @@ -102,6 +102,11 @@ static const struct fsl_soc_die_attr fsl_soc_die[] = {
> .svr = 0x87360000,
> .mask = 0xff3f0000,
> },
> + /* Die: LS1028A, SoC: LS1028A */
> + { .die = "LS1028A",
> + .svr = 0x870b0000,
> + .mask = 0xff3f0000,
> + },
> { },
> };
>
> @@ -224,6 +229,7 @@ static const struct of_device_id fsl_guts_of_match[] = {
> { .compatible = "fsl,ls1012a-dcfg", },
> { .compatible = "fsl,ls1046a-dcfg", },
> { .compatible = "fsl,lx2160a-dcfg", },
> + { .compatible = "fsl,ls1028a-dcfg", },
> {}
> };
> MODULE_DEVICE_TABLE(of, fsl_guts_of_match);
> --
> 2.17.1
>

2019-08-22 16:12:52

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH v1 4/4] mmc: sdhci-of-esdhc: add erratum A011334 support in ls1028a 1.0 SoC

On Wed, 14 Aug 2019 at 09:24, Yinbo Zhu <[email protected]> wrote:
>
> This patch is to add erratum A011334 support in ls1028a 1.0 SoC
>
> Signed-off-by: Yinbo Zhu <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index b16f7d440f78..eb2b290447fc 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -1006,6 +1006,7 @@ static struct soc_device_attribute soc_incorrect_hostver[] = {
> static struct soc_device_attribute soc_fixup_sdhc_clkdivs[] = {
> { .family = "QorIQ LX2160A", .revision = "1.0", },
> { .family = "QorIQ LX2160A", .revision = "2.0", },
> + { .family = "QorIQ LS1028A", .revision = "1.0", },
> { },
> };
>
> --
> 2.17.1
>

2019-11-22 03:33:56

by Yinbo Zhu

[permalink] [raw]
Subject: RE: [PATCH v1 1/4] arm64: dts: ls1028a-rdb: enable emmc hs400 mode

Hi

My hs400 series patches for ls1028 need do any changes?

Regards,
Yinbo Zhu.

-----Original Message-----
From: Yinbo Zhu <[email protected]>
Sent: 2019??8??14?? 15:27
To: Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Catalin Marinas <[email protected]>; Will Deacon <[email protected]>; Adrian Hunter <[email protected]>; Ulf Hansson <[email protected]>; Leo Li <[email protected]>; Claudiu Manoil <[email protected]>; Amit Jain (aj) <[email protected]>; Y.b. Lu <[email protected]>; Vabhav Sharma <[email protected]>; Rajesh Bhagat <[email protected]>; Ashish Kumar <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: Yinbo Zhu <[email protected]>; Xiaobo Xie <[email protected]>; Jiafei Pan <[email protected]>; Alison Wang <[email protected]>; Alexandru Marginean <[email protected]>; Catalin Horghidan <[email protected]>; Rajat Srivastava <[email protected]>; [email protected]
Subject: [PATCH v1 1/4] arm64: dts: ls1028a-rdb: enable emmc hs400 mode

This patch is to enable emmc hs400 mode for ls1028ardb

Signed-off-by: Yinbo Zhu <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
index 8a725409e881..f1e46cc4cea1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
@@ -92,8 +92,10 @@
};

&esdhc1 {
- status = "okay";
mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ bus-width = <8>;
+ status = "okay";
};

&i2c0 {
--
2.17.1

2019-12-10 00:07:21

by Michael Walle

[permalink] [raw]
Subject: Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

> dcfg use little endian that SoC register value will be correct
>
> Signed-off-by: Yinbo Zhu <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This patch is still missing. Any news?

Tested-by: Michael Walle <[email protected]>

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index b0d4f8916ede..5538e8e354b2 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -162,7 +162,7 @@
> dcfg: syscon@1e00000 {
> compatible = "fsl,ls1028a-dcfg", "syscon";
> reg = <0x0 0x1e00000 0x0 0x10000>;
> - big-endian;
> + little-endian;
> };
>
> scfg: syscon@1fc0000 {
> --
> 2.17.1
>

2019-12-10 02:36:23

by Yangbo Lu

[permalink] [raw]
Subject: RE: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

+ Shawn,

> -----Original Message-----
> From: Michael Walle <[email protected]>
> Sent: Tuesday, December 10, 2019 8:06 AM
> To: Yinbo Zhu <[email protected]>
> Cc: Ashish Kumar <[email protected]>; Alexandru Marginean
> <[email protected]>; Alison Wang <[email protected]>;
> Amit Jain (aj) <[email protected]>; [email protected]; Claudiu
> Manoil <[email protected]>; [email protected]; Jiafei Pan
> <[email protected]>; Leo Li <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Rajesh Bhagat <[email protected]>;
> [email protected]; Vabhav Sharma <[email protected]>; Xiaobo Xie
> <[email protected]>; Y.b. Lu <[email protected]>; Michael Walle
> <[email protected]>
> Subject: Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for
> dcfg
>

[Y.b. Lu] Acked-by: Yangbo Lu <[email protected]>

Hi Shawn, could you help to review and merge the two dts patches of this patch-set?
Thanks.

> > dcfg use little endian that SoC register value will be correct
> >
> > Signed-off-by: Yinbo Zhu <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch is still missing. Any news?
>
> Tested-by: Michael Walle <[email protected]>
>
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index b0d4f8916ede..5538e8e354b2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -162,7 +162,7 @@
> > dcfg: syscon@1e00000 {
> > compatible = "fsl,ls1028a-dcfg", "syscon";
> > reg = <0x0 0x1e00000 0x0 0x10000>;
> > - big-endian;
> > + little-endian;
> > };
> >
> > scfg: syscon@1fc0000 {
> > --
> > 2.17.1
> >

2019-12-11 09:15:53

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for dcfg

On Tue, Dec 10, 2019 at 02:34:30AM +0000, Y.b. Lu wrote:
> + Shawn,
>
> > -----Original Message-----
> > From: Michael Walle <[email protected]>
> > Sent: Tuesday, December 10, 2019 8:06 AM
> > To: Yinbo Zhu <[email protected]>
> > Cc: Ashish Kumar <[email protected]>; Alexandru Marginean
> > <[email protected]>; Alison Wang <[email protected]>;
> > Amit Jain (aj) <[email protected]>; [email protected]; Claudiu
> > Manoil <[email protected]>; [email protected]; Jiafei Pan
> > <[email protected]>; Leo Li <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected]; Rajesh Bhagat <[email protected]>;
> > [email protected]; Vabhav Sharma <[email protected]>; Xiaobo Xie
> > <[email protected]>; Y.b. Lu <[email protected]>; Michael Walle
> > <[email protected]>
> > Subject: Re: [PATCH v1 3/4] arm64: dts: ls1028a: fix little-big endian issue for
> > dcfg
> >
>
> [Y.b. Lu] Acked-by: Yangbo Lu <[email protected]>
>
> Hi Shawn, could you help to review and merge the two dts patches of this patch-set?
> Thanks.

Please resend them with me on recipients.

Shawn