On 2019/5/1 17:29, Rasmus Villemoes <[email protected]> wrote:
> -----Original Message-----
> From: Rasmus Villemoes <[email protected]>
> Sent: 2019年5月1日 17:29
> To: [email protected]; Qiang Zhao <[email protected]>; Leo Li
> <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Rob Herring <[email protected]>; Scott Wood
> <[email protected]>; Christophe Leroy <[email protected]>; Mark
> Rutland <[email protected]>; Rasmus Villemoes
> <[email protected]>
> Subject: [PATCH v2 5/6] soc/fsl/qe: qe.c: support fsl,qe-snums property
>
> Add driver support for the newly introduced fsl,qe-snums property.
>
> Conveniently, of_property_read_variable_u8_array does exactly what we
> need: If the property fsl,qe-snums is found (and has an allowed size), the array
> of values get copied to snums, and the return value is the number of snums -
> we cannot assign directly to num_of_snums, since we need to check whether
> the return value is negative.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>
> ---
Reviewed-by: Qiang Zhao <[email protected]>
> drivers/soc/fsl/qe/qe.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> 0fb8b59f61ad..325d689cbf5c 100644
> --- a/drivers/soc/fsl/qe/qe.c
> +++ b/drivers/soc/fsl/qe/qe.c
> @@ -283,7 +283,6 @@ EXPORT_SYMBOL(qe_clock_source);
> */
> static void qe_snums_init(void)
> {
> - int i;
> static const u8 snum_init_76[] = {
> 0x04, 0x05, 0x0C, 0x0D, 0x14, 0x15, 0x1C, 0x1D,
> 0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35, 0x88, 0x89, @@
> -304,7 +303,21 @@ static void qe_snums_init(void)
> 0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
> 0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
> };
> + struct device_node *qe;
> const u8 *snum_init;
> + int i;
> +
> + bitmap_zero(snum_state, QE_NUM_OF_SNUM);
> + qe = qe_get_device_node();
> + if (qe) {
> + i = of_property_read_variable_u8_array(qe, "fsl,qe-snums",
> + snums, 1,
> QE_NUM_OF_SNUM);
> + of_node_put(qe);
> + if (i > 0) {
> + qe_num_of_snum = i;
> + return;
> + }
> + }
>
> qe_num_of_snum = qe_get_num_of_snums();
>
> @@ -313,7 +326,6 @@ static void qe_snums_init(void)
> else
> snum_init = snum_init_46;
>
> - bitmap_zero(snum_state, QE_NUM_OF_SNUM);
> memcpy(snums, snum_init, qe_num_of_snum); }
>
> --
> 2.20.1
Best Regards
Qiang Zhao