2019-11-23 20:17:37

by Michael Walle

Subject: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data

This was tested on a custom board.

Signed-off-by: Michael Walle <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index dc75534a4754..f2e71fd57b20 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -573,7 +573,7 @@
0x00010004 0x0000003d
0x00010005 0x00000045
0x00010006 0x0000004d
- 0x00010007 0x00000045
+ 0x00010007 0x00000055
0x00010008 0x0000005e
0x00010009 0x00000066
0x0001000a 0x0000006e
--
2.20.1

2019-12-09 06:27:15

by Shawn Guo

Subject: Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data

+ Yuantian Tang, who is the author of existing code.

On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> This was tested on a custom board.

Can you add more info about why this is an error and how it is being
identified?

Shawn

>
> Signed-off-by: Michael Walle <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index dc75534a4754..f2e71fd57b20 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -573,7 +573,7 @@
> 0x00010004 0x0000003d
> 0x00010005 0x00000045
> 0x00010006 0x0000004d
> - 0x00010007 0x00000045
> + 0x00010007 0x00000055
> 0x00010008 0x0000005e
> 0x00010009 0x00000066
> 0x0001000a 0x0000006e
> --
> 2.20.1
>

2019-12-09 06:40:56

by Andy Tang

Subject: RE: [EXT] Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data

Hi Shawn,

> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: 2019??12??9?? 14:25
> To: Michael Walle <[email protected]>; Andy Tang <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; Leo Li <[email protected]>; Rob Herring
> <[email protected]>; Mark Rutland <[email protected]>
> Subject: [EXT] Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU
> calibration data
>
> Caution: EXT Email
>
> + Yuantian Tang, who is the author of existing code.
>
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
> > This was tested on a custom board.
>
> Can you add more info about why this is an error and how it is being
> identified?

I am not sure how Michael figured out this error but he/she is correct.
I must have made a mistake when sending these data out.

Thanks Shawn and Michael.

Acked-by: Tang Yuantian <[email protected]>

BR,
Andy
>
> Shawn
>
> >
> > Signed-off-by: Michael Walle <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index dc75534a4754..f2e71fd57b20 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -573,7 +573,7 @@
> > 0x00010004
> 0x0000003d
> > 0x00010005
> 0x00000045
> > 0x00010006
> 0x0000004d
> > - 0x00010007
> 0x00000045
> > + 0x00010007
> 0x00000055
> > 0x00010008
> 0x0000005e
> > 0x00010009
> 0x00000066
> > 0x0001000a
> 0x0000006e
> > --
> > 2.20.1
> >

2019-12-09 08:43:51

by Michael Walle

Subject: Re: [PATCH 1/4] arm64: dts: ls1028a: fix typo in TMU calibration data

Am 2019-12-09 07:24, schrieb Shawn Guo:
> + Yuantian Tang, who is the author of existing code.
>
> On Sat, Nov 23, 2019 at 09:13:14PM +0100, Michael Walle wrote:
>> This was tested on a custom board.
>
> Can you add more info about why this is an error and how it is being
> identified?

sorry. there was a more elaborate commit message. something went wrong
here.

-michael

>
> Shawn
>
>>
>> Signed-off-by: Michael Walle <[email protected]>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index dc75534a4754..f2e71fd57b20 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -573,7 +573,7 @@
>> 0x00010004 0x0000003d
>> 0x00010005 0x00000045
>> 0x00010006 0x0000004d
>> - 0x00010007 0x00000045
>> + 0x00010007 0x00000055
>> 0x00010008 0x0000005e
>> 0x00010009 0x00000066
>> 0x0001000a 0x0000006e
>> --
>> 2.20.1
>>