From: Yogesh Gaur <[email protected]>
Add clockgen support for lx2160a.
Added entry for compat 'fsl,lx2160a-clockgen'.
Signed-off-by: Tang Yuantian <[email protected]>
Signed-off-by: Yogesh Gaur <[email protected]>
Signed-off-by: Vabhav Sharma <[email protected]>
Acked-by: Scott Wood <[email protected]>
Acked-by: Stephen Boyd <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
---
Changes for v2:
- Subject line updated
drivers/clk/clk-qoriq.c | 12 ++++++++++++
drivers/cpufreq/qoriq-cpufreq.c | 1 +
2 files changed, 13 insertions(+)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 3d51d7c..1a15201 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
.flags = CG_VER3 | CG_LITTLE_ENDIAN,
},
{
+ .compat = "fsl,lx2160a-clockgen",
+ .cmux_groups = {
+ &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
+ },
+ .cmux_to_group = {
+ 0, 0, 0, 0, 1, 1, 1, 1, -1
+ },
+ .pll_mask = 0x37,
+ .flags = CG_VER3 | CG_LITTLE_ENDIAN,
+ },
+ {
.compat = "fsl,p2041-clockgen",
.guts_compat = "fsl,qoriq-device-config-1.0",
.init_periph = p2041_init_periph,
@@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
+CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
index 4295e54..81f0288 100644
--- a/drivers/cpufreq/qoriq-cpufreq.c
+++ b/drivers/cpufreq/qoriq-cpufreq.c
@@ -284,6 +284,7 @@ static const struct of_device_id node_matches[] __initconst = {
{ .compatible = "fsl,ls1046a-clockgen", },
{ .compatible = "fsl,ls1088a-clockgen", },
{ .compatible = "fsl,ls2080a-clockgen", },
+ { .compatible = "fsl,lx2160a-clockgen", },
{ .compatible = "fsl,p4080-clockgen", },
{ .compatible = "fsl,qoriq-clockgen-1.0", },
{ .compatible = "fsl,qoriq-clockgen-2.0", },
--
2.7.4
> -----Original Message-----
> From: Rafael J. Wysocki <[email protected]>
> Sent: 2019年4月25日 18:04
> To: Vabhav Sharma <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Yogesh Narayan Gaur
> <[email protected]>; Andy Tang <[email protected]>
> Subject: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for lx2160a
>
> Caution: EXT Email
>
> On Thu, Apr 25, 2019 at 11:48 AM Vabhav Sharma <[email protected]>
> wrote:
> >
> > From: Yogesh Gaur <[email protected]>
> >
> > Add clockgen support for lx2160a.
> > Added entry for compat 'fsl,lx2160a-clockgen'.
>
> Well, if I'm expected to apply this, the above is a bit terse.
>
> It looks like the patch makes the qoriq-cpufreq driver handle some new
> hardware, but the changelog doesn't say much about that.
>
> I'm guessing that the clockgen support added here makes it possible for
> qoriq-cpufreq to handle this chip, is that correct?
Yes, your guess is correct. The cpufreq feature is based on clock driver.
It should had been separated to two patches and reduced the confuse.
Do I need to update the commit message or you just take it?
BR,
Andy
>
> > Signed-off-by: Tang Yuantian <[email protected]>
> > Signed-off-by: Yogesh Gaur <[email protected]>
> > Signed-off-by: Vabhav Sharma <[email protected]>
> > Acked-by: Scott Wood <[email protected]>
> > Acked-by: Stephen Boyd <[email protected]>
> > Acked-by: Viresh Kumar <[email protected]>
> > ---
> > Changes for v2:
> > - Subject line updated
> >
> > drivers/clk/clk-qoriq.c | 12 ++++++++++++
> > drivers/cpufreq/qoriq-cpufreq.c | 1 +
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 3d51d7c..1a15201 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> > .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > },
> > {
> > + .compat = "fsl,lx2160a-clockgen",
> > + .cmux_groups = {
> > + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > + },
> > + .cmux_to_group = {
> > + 0, 0, 0, 0, 1, 1, 1, 1, -1
> > + },
> > + .pll_mask = 0x37,
> > + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > + },
> > + {
> > .compat = "fsl,p2041-clockgen",
> > .guts_compat = "fsl,qoriq-device-config-1.0",
> > .init_periph = p2041_init_periph, @@ -1427,6 +1438,7
> > @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1046a,
> > "fsl,ls1046a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > +clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > "fsl,p3041-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > clockgen_init); diff --git a/drivers/cpufreq/qoriq-cpufreq.c
> > b/drivers/cpufreq/qoriq-cpufreq.c index 4295e54..81f0288 100644
> > --- a/drivers/cpufreq/qoriq-cpufreq.c
> > +++ b/drivers/cpufreq/qoriq-cpufreq.c
> > @@ -284,6 +284,7 @@ static const struct of_device_id node_matches[]
> __initconst = {
> > { .compatible = "fsl,ls1046a-clockgen", },
> > { .compatible = "fsl,ls1088a-clockgen", },
> > { .compatible = "fsl,ls2080a-clockgen", },
> > + { .compatible = "fsl,lx2160a-clockgen", },
> > { .compatible = "fsl,p4080-clockgen", },
> > { .compatible = "fsl,qoriq-clockgen-1.0", },
> > { .compatible = "fsl,qoriq-clockgen-2.0", },
> > --
> > 2.7.4
> >
On Thu, Apr 25, 2019 at 12:15 PM Andy Tang <[email protected]> wrote:
>
>
> > -----Original Message-----
> > From: Rafael J. Wysocki <[email protected]>
> > Sent: 2019年4月25日 18:04
> > To: Vabhav Sharma <[email protected]>
> > Cc: [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; Yogesh Narayan Gaur
> > <[email protected]>; Andy Tang <[email protected]>
> > Subject: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for lx2160a
> >
> > Caution: EXT Email
> >
> > On Thu, Apr 25, 2019 at 11:48 AM Vabhav Sharma <[email protected]>
> > wrote:
> > >
> > > From: Yogesh Gaur <[email protected]>
> > >
> > > Add clockgen support for lx2160a.
> > > Added entry for compat 'fsl,lx2160a-clockgen'.
> >
> > Well, if I'm expected to apply this, the above is a bit terse.
> >
> > It looks like the patch makes the qoriq-cpufreq driver handle some new
> > hardware, but the changelog doesn't say much about that.
> >
> > I'm guessing that the clockgen support added here makes it possible for
> > qoriq-cpufreq to handle this chip, is that correct?
> Yes, your guess is correct. The cpufreq feature is based on clock driver.
> It should had been separated to two patches and reduced the confuse.
> Do I need to update the commit message or you just take it?
Please update the commit message.
Thanks!
> -----Original Message-----
> From: Rafael J. Wysocki <[email protected]>
> Sent: Thursday, April 25, 2019 3:59 PM
> To: Andy Tang <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>; Vabhav Sharma
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Yogesh Narayan Gaur <[email protected]>
> Subject: Re: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for lx2160a
>
> Caution: EXT Email
>
> On Thu, Apr 25, 2019 at 12:15 PM Andy Tang <[email protected]> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Rafael J. Wysocki <[email protected]>
> > > Sent: 2019年4月25日 18:04
> > > To: Vabhav Sharma <[email protected]>
> > > Cc: [email protected]; [email protected];
> > > [email protected]; [email protected]; [email protected];
> > > [email protected]; [email protected]; Yogesh Narayan Gaur
> > > <[email protected]>; Andy Tang <[email protected]>
> > > Subject: [EXT] Re: [PATCH v2] clk: qoriq: Add clockgen support for
> > > lx2160a
> > >
> > > Caution: EXT Email
> > >
> > > On Thu, Apr 25, 2019 at 11:48 AM Vabhav Sharma
> > > <[email protected]>
> > > wrote:
> > > >
> > > > From: Yogesh Gaur <[email protected]>
> > > >
> > > > Add clockgen support for lx2160a.
> > > > Added entry for compat 'fsl,lx2160a-clockgen'.
> > >
> > > Well, if I'm expected to apply this, the above is a bit terse.
> > >
> > > It looks like the patch makes the qoriq-cpufreq driver handle some
> > > new hardware, but the changelog doesn't say much about that.
> > >
> > > I'm guessing that the clockgen support added here makes it possible
> > > for qoriq-cpufreq to handle this chip, is that correct?
> > Yes, your guess is correct. The cpufreq feature is based on clock driver.
> > It should had been separated to two patches and reduced the confuse.
> > Do I need to update the commit message or you just take it?
>
> Please update the commit message.
>
> Thanks!
Ok
On Thu, Apr 25, 2019 at 11:48 AM Vabhav Sharma <[email protected]> wrote:
>
> From: Yogesh Gaur <[email protected]>
>
> Add clockgen support for lx2160a.
> Added entry for compat 'fsl,lx2160a-clockgen'.
Well, if I'm expected to apply this, the above is a bit terse.
It looks like the patch makes the qoriq-cpufreq driver handle some new
hardware, but the changelog doesn't say much about that.
I'm guessing that the clockgen support added here makes it possible
for qoriq-cpufreq to handle this chip, is that correct?
> Signed-off-by: Tang Yuantian <[email protected]>
> Signed-off-by: Yogesh Gaur <[email protected]>
> Signed-off-by: Vabhav Sharma <[email protected]>
> Acked-by: Scott Wood <[email protected]>
> Acked-by: Stephen Boyd <[email protected]>
> Acked-by: Viresh Kumar <[email protected]>
> ---
> Changes for v2:
> - Subject line updated
>
> drivers/clk/clk-qoriq.c | 12 ++++++++++++
> drivers/cpufreq/qoriq-cpufreq.c | 1 +
> 2 files changed, 13 insertions(+)
>
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index 3d51d7c..1a15201 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> },
> {
> + .compat = "fsl,lx2160a-clockgen",
> + .cmux_groups = {
> + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> + },
> + .cmux_to_group = {
> + 0, 0, 0, 0, 1, 1, 1, 1, -1
> + },
> + .pll_mask = 0x37,
> + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> + },
> + {
> .compat = "fsl,p2041-clockgen",
> .guts_compat = "fsl,qoriq-device-config-1.0",
> .init_periph = p2041_init_periph,
> @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a, "fsl,ls1043a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen", clockgen_init);
> +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p3041, "fsl,p3041-clockgen", clockgen_init);
> CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen", clockgen_init);
> diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c
> index 4295e54..81f0288 100644
> --- a/drivers/cpufreq/qoriq-cpufreq.c
> +++ b/drivers/cpufreq/qoriq-cpufreq.c
> @@ -284,6 +284,7 @@ static const struct of_device_id node_matches[] __initconst = {
> { .compatible = "fsl,ls1046a-clockgen", },
> { .compatible = "fsl,ls1088a-clockgen", },
> { .compatible = "fsl,ls2080a-clockgen", },
> + { .compatible = "fsl,lx2160a-clockgen", },
> { .compatible = "fsl,p4080-clockgen", },
> { .compatible = "fsl,qoriq-clockgen-1.0", },
> { .compatible = "fsl,qoriq-clockgen-2.0", },
> --
> 2.7.4
>