2019-06-28 03:37:43

by Anson Huang

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet

From: Anson Huang <[email protected]>

According to latest datasheet (Rev.0.2, 04/2019) from below links,
1.8GHz is ONLY available for consumer part, so the market segment
bits for 1.8GHz opp should ONLY available for consumer part accordingly.

https://www.nxp.com/docs/en/data-sheet/IMX8MMIEC.pdf
https://www.nxp.com/docs/en/data-sheet/IMX8MMCEC.pdf

Fixes: f403a26c865b (arm64: dts: imx8mm: Add cpu speed grading and all OPPs)
Signed-off-by: Anson Huang <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index c38813d..ab0d135 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -135,7 +135,7 @@
opp-hz = /bits/ 64 <1800000000>;
opp-microvolt = <1000000>;
/* Consumer only but rely on speed grading */
- opp-supported-hw = <0x8>, <0x7>;
+ opp-supported-hw = <0x8>, <0x3>;
clock-latency-ns = <150000>;
};
};
--
2.7.4


2019-06-28 06:02:57

by Leonard Crestez

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet

On 28.06.2019 06:37, [email protected] wrote:

> According to latest datasheet (Rev.0.2, 04/2019) from below links,
> 1.8GHz is ONLY available for consumer part, so the market segment
> bits for 1.8GHz opp should ONLY available for consumer part accordingly.
>
> opp-hz = /bits/ 64 <1800000000>;
> opp-microvolt = <1000000>;
> /* Consumer only but rely on speed grading */
> - opp-supported-hw = <0x8>, <0x7>;
> + opp-supported-hw = <0x8>, <0x3>;

Only consumer parts should be fused for this highest OPP. If you don't
want to rely on this then maybe also delete the comment above?

--
Regards,
leonard

2019-06-28 06:17:46

by Anson Huang

[permalink] [raw]
Subject: RE: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to latest datasheet

Hi, Leonard

> -----Original Message-----
> From: Leonard Crestez
> Sent: Friday, June 28, 2019 2:01 PM
> To: Anson Huang <[email protected]>; Jacky Bai <[email protected]>;
> [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Daniel Baluta <[email protected]>; Abel
> Vesa <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]; dl-linux-imx <[email protected]>
> Subject: Re: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to
> latest datasheet
>
> On 28.06.2019 06:37, [email protected] wrote:
>
> > According to latest datasheet (Rev.0.2, 04/2019) from below links,
> > 1.8GHz is ONLY available for consumer part, so the market segment bits
> > for 1.8GHz opp should ONLY available for consumer part accordingly.
> >
> > opp-hz = /bits/ 64 <1800000000>;
> > opp-microvolt = <1000000>;
> > /* Consumer only but rely on speed grading */
> > - opp-supported-hw = <0x8>, <0x7>;
> > + opp-supported-hw = <0x8>, <0x3>;
>
> Only consumer parts should be fused for this highest OPP. If you don't want
> to rely on this then maybe also delete the comment above?

As I replied in previous i.MX8MQ patch, if the comments make reader confused,
should we just remove all those comments?

Thanks,
Anson.

>
> --
> Regards,
> leonard