The is_imx6q_usdhc() function is unused:
drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function 'is_imx6q_usdhc'
Reported-by: kernel test robot <[email protected]>
Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index fba4a963d12e..7336ae749137 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct pltfm_imx_data *data)
return data->socdata == &esdhc_imx53_data;
}
-static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)
-{
- return data->socdata == &usdhc_imx6q_data;
-}
-
static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)
{
return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
--
2.27.0
The sdhci_sprd_writew() was defined by never used in sdhci_ops:
drivers/mmc/host/sdhci-sprd.c:134:20: warning: unused function 'sdhci_sprd_writew'
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mmc/host/sdhci-sprd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 5dc36efff47f..11e375579cfb 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -393,6 +393,7 @@ static void sdhci_sprd_request_done(struct sdhci_host *host,
static struct sdhci_ops sdhci_sprd_ops = {
.read_l = sdhci_sprd_readl,
.write_l = sdhci_sprd_writel,
+ .write_w = sdhci_sprd_writew,
.write_b = sdhci_sprd_writeb,
.set_clock = sdhci_sprd_set_clock,
.get_max_clock = sdhci_sprd_get_max_clock,
--
2.27.0
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:[email protected]]
> Sent: 2021??6??1?? 17:54
> To: Adrian Hunter <[email protected]>; Ulf Hansson
> <[email protected]>; Shawn Guo <[email protected]>; Sascha
> Hauer <[email protected]>; Pengutronix Kernel Team
> <[email protected]>; Fabio Estevam <[email protected]>;
> dl-linux-imx <[email protected]>; Orson Zhai <[email protected]>;
> Baolin Wang <[email protected]>; Chunyan Zhang
> <[email protected]>; [email protected];
> [email protected]; [email protected]
> Cc: Krzysztof Kozlowski <[email protected]>; kernel test
> robot <[email protected]>
> Subject: [PATCH 1/2] mmc: sdhci-esdhc-imx: remove unused is_imx6q_usdhc
>
> The is_imx6q_usdhc() function is unused:
>
> drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function
> 'is_imx6q_usdhc'
Reviewed-by: Haibo Chen <[email protected]>
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c
> b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct
> pltfm_imx_data *data)
> return data->socdata == &esdhc_imx53_data; }
>
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data) -{
> - return data->socdata == &usdhc_imx6q_data;
> -}
> -
> static inline int esdhc_is_usdhc(struct pltfm_imx_data *data) {
> return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
On Tue, 1 Jun 2021 at 11:54, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The is_imx6q_usdhc() function is unused:
>
> drivers/mmc/host/sdhci-esdhc-imx.c:343:19: warning: unused function 'is_imx6q_usdhc'
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: f47c4bbfa283 ("mmc: sdhci-esdhc-imx: create struct esdhc_soc_data")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index fba4a963d12e..7336ae749137 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -324,11 +324,6 @@ static inline int is_imx53_esdhc(struct pltfm_imx_data *data)
> return data->socdata == &esdhc_imx53_data;
> }
>
> -static inline int is_imx6q_usdhc(struct pltfm_imx_data *data)
> -{
> - return data->socdata == &usdhc_imx6q_data;
> -}
> -
> static inline int esdhc_is_usdhc(struct pltfm_imx_data *data)
> {
> return !!(data->socdata->flags & ESDHC_FLAG_USDHC);
> --
> 2.27.0
>
On Tue, 1 Jun 2021 at 11:54, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The sdhci_sprd_writew() was defined by never used in sdhci_ops:
>
> drivers/mmc/host/sdhci-sprd.c:134:20: warning: unused function 'sdhci_sprd_writew'
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-sprd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 5dc36efff47f..11e375579cfb 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -393,6 +393,7 @@ static void sdhci_sprd_request_done(struct sdhci_host *host,
> static struct sdhci_ops sdhci_sprd_ops = {
> .read_l = sdhci_sprd_readl,
> .write_l = sdhci_sprd_writel,
> + .write_w = sdhci_sprd_writew,
> .write_b = sdhci_sprd_writeb,
> .set_clock = sdhci_sprd_set_clock,
> .get_max_clock = sdhci_sprd_get_max_clock,
> --
> 2.27.0
>