There aren't enough resources to run these ports at 10G speeds. Disable
10G for these ports, reverting to the previous speed.
Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
Reported-by: Camelia Alexandra Groza <[email protected]>
Signed-off-by: Sean Anderson <[email protected]>
---
Changes in v2:
- Remove the 10g properties, instead of removing the MAC dtsis.
arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
index 74e17e134387..27714dc2f04a 100644
--- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
@@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
interrupts = <16 2 1 9>;
};
};
+
+&fman0_rx_0x08 {
+ /delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_tx_0x28 {
+ /delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_rx_0x09 {
+ /delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_tx_0x29 {
+ /delete-property/ fsl,fman-10g-port;
+};
--
2.35.1.1320.gc452695387.dirty
> -----Original Message-----
> From: Sean Anderson <[email protected]>
> Sent: Friday, December 16, 2022 19:30
> To: David S . Miller <[email protected]>; [email protected]
> Cc: [email protected]; Rob Herring <[email protected]>;
> Christophe Leroy <[email protected]>; Nicholas Piggin
> <[email protected]>; Michael Ellerman <[email protected]>; linuxppc-
> [email protected]; Krzysztof Kozlowski
> <[email protected]>; [email protected]; Camelia
> Alexandra Groza <[email protected]>; Sean Anderson
> <[email protected]>
> Subject: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> MAC2
>
> There aren't enough resources to run these ports at 10G speeds. Disable
> 10G for these ports, reverting to the previous speed.
>
> Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> Reported-by: Camelia Alexandra Groza <[email protected]>
> Signed-off-by: Sean Anderson <[email protected]>
> ---
Thank you.
Reviewed-by: Camelia Groza <[email protected]>
Tested-by: Camelia Groza <[email protected]>
> Changes in v2:
> - Remove the 10g properties, instead of removing the MAC dtsis.
>
> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> index 74e17e134387..27714dc2f04a 100644
> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> @@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
> interrupts = <16 2 1 9>;
> };
> };
> +
> +&fman0_rx_0x08 {
> + /delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_tx_0x28 {
> + /delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_rx_0x09 {
> + /delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_tx_0x29 {
> + /delete-property/ fsl,fman-10g-port;
> +};
> --
> 2.35.1.1320.gc452695387.dirty
> -----Original Message-----
> From: Camelia Alexandra Groza <[email protected]>
> Sent: Monday, December 19, 2022 18:23
> To: Sean Anderson <[email protected]>; David S . Miller
> <[email protected]>; [email protected]
> Cc: [email protected]; Rob Herring <[email protected]>;
> Christophe Leroy <[email protected]>; Nicholas Piggin
> <[email protected]>; Michael Ellerman <[email protected]>; linuxppc-
> [email protected]; Krzysztof Kozlowski
> <[email protected]>; [email protected]; Sean
> Anderson <[email protected]>
> Subject: RE: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> MAC2
>
> > -----Original Message-----
> > From: Sean Anderson <[email protected]>
> > Sent: Friday, December 16, 2022 19:30
> > To: David S . Miller <[email protected]>; [email protected]
> > Cc: [email protected]; Rob Herring <[email protected]>;
> > Christophe Leroy <[email protected]>; Nicholas Piggin
> > <[email protected]>; Michael Ellerman <[email protected]>; linuxppc-
> > [email protected]; Krzysztof Kozlowski
> > <[email protected]>; [email protected];
> Camelia
> > Alexandra Groza <[email protected]>; Sean Anderson
> > <[email protected]>
> > Subject: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> > MAC2
> >
> > There aren't enough resources to run these ports at 10G speeds. Disable
> > 10G for these ports, reverting to the previous speed.
> >
> > Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> > Reported-by: Camelia Alexandra Groza <[email protected]>
> > Signed-off-by: Sean Anderson <[email protected]>
> > ---
>
> Thank you.
>
> Reviewed-by: Camelia Groza <[email protected]>
> Tested-by: Camelia Groza <[email protected]>
I see the patch marked Not Applicable in the netdev patchwork.
What tree will it go through?
> > Changes in v2:
> > - Remove the 10g properties, instead of removing the MAC dtsis.
> >
> > arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > index 74e17e134387..27714dc2f04a 100644
> > --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > @@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
> > interrupts = <16 2 1 9>;
> > };
> > };
> > +
> > +&fman0_rx_0x08 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x28 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_rx_0x09 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x29 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > --
> > 2.35.1.1320.gc452695387.dirty
On Thu, 22 Dec 2022 15:41:00 +0000 Camelia Alexandra Groza wrote:
> > Reviewed-by: Camelia Groza <[email protected]>
> > Tested-by: Camelia Groza <[email protected]>
>
> I see the patch marked Not Applicable in the netdev patchwork.
> What tree will it go through?
I could be wrong but I think DTS patches are supposed to go via the
platform / arch trees. We mostly take bindings via the networking trees
(and DTS changes if they are part of a larger code+binding+dts set).
But we can obviously apply this patch if that's the preference of
the PowerPC maintainers..
Jakub Kicinski <[email protected]> writes:
> On Thu, 22 Dec 2022 15:41:00 +0000 Camelia Alexandra Groza wrote:
>> > Reviewed-by: Camelia Groza <[email protected]>
>> > Tested-by: Camelia Groza <[email protected]>
>>
>> I see the patch marked Not Applicable in the netdev patchwork.
>> What tree will it go through?
>
> I could be wrong but I think DTS patches are supposed to go via the
> platform / arch trees. We mostly take bindings via the networking trees
> (and DTS changes if they are part of a larger code+binding+dts set).
> But we can obviously apply this patch if that's the preference of
> the PowerPC maintainers..
The commit it Fixes went in via the networking tree, so I think it would
make sense for you to take this also via the networking tree.
cheers
On Fri, 23 Dec 2022 10:30:36 +1100 Michael Ellerman wrote:
> The commit it Fixes went in via the networking tree, so I think it would
> make sense for you to take this also via the networking tree.
Roger that, thanks for confirming.
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
On Fri, 16 Dec 2022 12:29:37 -0500 you wrote:
> There aren't enough resources to run these ports at 10G speeds. Disable
> 10G for these ports, reverting to the previous speed.
>
> Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> Reported-by: Camelia Alexandra Groza <[email protected]>
> Signed-off-by: Sean Anderson <[email protected]>
>
> [...]
Here is the summary with links:
- [net,v2] powerpc: dts: t208x: Disable 10G on MAC1 and MAC2
https://git.kernel.org/netdev/net/c/8d8bee13ae9e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html